Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1756583002: Pack float array uniforms into vec4 arrays (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Some cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M src/gpu/effects/GrConvolutionEffect.cpp View 1 3 chunks +11 lines, -4 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
It's unclear to me how to make it general without adding a lot of special ...
4 years, 9 months ago (2016-03-02 19:55:50 UTC) #3
egdaniel
lgtm
4 years, 9 months ago (2016-03-02 20:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756583002/20001
4 years, 9 months ago (2016-03-02 21:10:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 21:21:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/78d6eb07753f3befd34b4cbda4bb975bfcc021c4

Powered by Google App Engine
This is Rietveld 408576698