Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756503003: NTP4: remove unused promo C++ (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
Robert Sesek, sky
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, pedrosimonetti+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@bubble-promo-ui
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP4: remove unused promo C++ R=rsesek@chromium.org TBR=sky@chromium.org BUG=329637, 576772 Committed: https://crrev.com/66d7184c7db7a657022286412716a0ac1912896b Cr-Commit-Position: refs/heads/master@{#378709}

Patch Set 1 : check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -151 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_login_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.h View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 7 chunks +3 lines, -44 lines 0 comments Download

Depends on Patchset:

Issue 1754853002 Patch 20001

Dependent Patchsets:

Issue 1757673002 Patch 1

Messages

Total messages: 20 (12 generated)
Dan Beam
4 years, 9 months ago (2016-03-01 23:02:30 UTC) #6
Robert Sesek
LGTM. Thanks!
4 years, 9 months ago (2016-03-02 00:38:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756503003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756503003/80001
4 years, 9 months ago (2016-03-02 04:52:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/152356)
4 years, 9 months ago (2016-03-02 05:02:15 UTC) #11
Dan Beam
TBR=sky for removed (now) dead notification
4 years, 9 months ago (2016-03-02 07:21:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756503003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756503003/80001
4 years, 9 months ago (2016-03-02 07:21:47 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 9 months ago (2016-03-02 07:29:12 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 07:30:33 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66d7184c7db7a657022286412716a0ac1912896b
Cr-Commit-Position: refs/heads/master@{#378709}

Powered by Google App Engine
This is Rietveld 408576698