NTP4: erase bubble promo UI

NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637, 576772
Committed: https://crrev.com/cf6b71e7009543906d6c48aa1ac90c1d1e27590a
Cr-Commit-Position: refs/heads/master@{#378685}

[Dan Beam, 2016-03-01 21:52:23]

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/new_tab.js (right):

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/new_tab.js:83: NewTabView.prototype = {__proto__:
ntp.PageListView.prototype};
could I fix this silly single inheritance?  yes, but it's not high on my
priority list at the moment

[Evan Stade, 2016-03-01 22:25:34]

lgtm

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/new_tab.js (right):

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/new_tab.js:83: NewTabView.prototype = {__proto__:
ntp.PageListView.prototype};
On 2016/03/01 21:52:22, Dan Beam wrote:
> could I fix this silly single inheritance?  yes, but it's not high on my
> priority list at the moment

at least a TODO would be nice

[Dan Beam, 2016-03-01 22:36:06]

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/new_tab.js (right):

https://codereview.chromium.org/1754853002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/new_tab.js:83: NewTabView.prototype = {__proto__:
ntp.PageListView.prototype};
On 2016/03/01 22:25:34, Evan Stade wrote:
> On 2016/03/01 21:52:22, Dan Beam wrote:
> > could I fix this silly single inheritance?  yes, but it's not high on my
> > priority list at the moment
> 
> at least a TODO would be nice

Done.

[Dan Beam, 2016-03-01 22:36:19]

Description was changed from

==========
NTP4: remove bubble promo UI

R=estade@chromium.org
BUG=329637,576772
==========

to

==========
NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637,576772
==========

[Dan Beam, 2016-03-01 23:52:23]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-01 23:52:23]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1754853002/#ps20001
(title: "todo")

[commit-bot: I haz the power, 2016-03-01 23:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754853002/20001

[commit-bot: I haz the power, 2016-03-02 00:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:32:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-03-02 00:37:04]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:37:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754853002/20001

[commit-bot: I haz the power, 2016-03-02 03:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 03:06:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-03-02 03:46:22]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-03-02 03:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754853002/20001

[commit-bot: I haz the power, 2016-03-02 04:13:41]

Description was changed from

==========
NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637,576772
==========

to

==========
NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637,576772
==========

[commit-bot: I haz the power, 2016-03-02 04:13:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-02 04:15:20]

Description was changed from

==========
NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637,576772
==========

to

==========
NTP4: erase bubble promo UI

R=estade@chromium.org
BUG=329637,576772

Committed: https://crrev.com/cf6b71e7009543906d6c48aa1ac90c1d1e27590a
Cr-Commit-Position: refs/heads/master@{#378685}
==========

[commit-bot: I haz the power, 2016-03-02 04:15:21]

Patchset 2 (id:??) landed as
https://crrev.com/cf6b71e7009543906d6c48aa1ac90c1d1e27590a
Cr-Commit-Position: refs/heads/master@{#378685}