NTP4/apps page: fix page stickiness

NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
Committed: https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e
Cr-Commit-Position: refs/heads/master@{#379115}

[Dan Beam, 2016-03-02 00:02:53]

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/page_list_view.js (right):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:499: if
(loadTimeData.getBoolean('showApps')) {
yeah, I know, this is probably never false...

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:626: if
(page.classList.contains('apps-page'))
and this is probably never false either...

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/new_tab_ui.cc (left):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/new_tab_ui.cc:105: web_ui->AddMessageHandler(new
AppLauncherHandler(service));
this is where the equivalent handler is added

[Marc Treib, 2016-03-02 20:27:18]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-03-02 20:27:19]

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/new_tab_ui.cc (left):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/new_tab_ui.cc:105: web_ui->AddMessageHandler(new
AppLauncherHandler(service));
On 2016/03/02 00:02:53, Dan Beam wrote:
> this is where the equivalent handler is added

For chrome://apps, where the handler is actually used, it is instantiated here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[Dan Beam, 2016-03-03 17:40:22]

ping estade

[Dan Beam, 2016-03-03 17:40:29]

Description was changed from

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
==========

to

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
==========

[Dan Beam, 2016-03-03 17:40:30]

dbeam@chromium.org changed reviewers:
- treib@chromium.org

[Evan Stade, 2016-03-03 19:59:53]

lgtm

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/page_list_view.js (right):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:499: if
(loadTimeData.getBoolean('showApps')) {
On 2016/03/02 00:02:53, Dan Beam wrote:
> yeah, I know, this is probably never false...

todo?

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:626: if
(page.classList.contains('apps-page'))
On 2016/03/02 00:02:53, Dan Beam wrote:
> and this is probably never false either...

todo

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:226: // TODO(estade): should
be syncable.
this is so meh-worthy I wouldn't mind if you removed the todo

[Dan Beam, 2016-03-03 21:09:41]

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/page_list_view.js (right):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:165: // TODO(dbeam): remove
showApps and everything that says if (apps).
^

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:499: if
(loadTimeData.getBoolean('showApps')) {
On 2016/03/03 19:59:53, Evan Stade wrote:
> On 2016/03/02 00:02:53, Dan Beam wrote:
> > yeah, I know, this is probably never false...
> 
> todo?

Done. (previously)

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/page_list_view.js:626: if
(page.classList.contains('apps-page'))
On 2016/03/03 19:59:53, Evan Stade wrote:
> On 2016/03/02 00:02:53, Dan Beam wrote:
> > and this is probably never false either...
> 
> todo

Done.

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

https://codereview.chromium.org/1757673002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:226: // TODO(estade): should
be syncable.
On 2016/03/03 19:59:53, Evan Stade wrote:
> this is so meh-worthy I wouldn't mind if you removed the todo

Done.

[Dan Beam, 2016-03-03 22:20:38]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-03 22:20:38]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1757673002/#ps20001
(title: "todookie")

[commit-bot: I haz the power, 2016-03-03 22:21:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757673002/20001

[commit-bot: I haz the power, 2016-03-03 22:28:17]

Description was changed from

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
==========

to

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
==========

[commit-bot: I haz the power, 2016-03-03 22:28:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 22:29:21]

Description was changed from

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225
==========

to

==========
NTP4/apps page: fix page stickiness

R=estade@chromium.org
BUG=591225

Committed: https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e
Cr-Commit-Position: refs/heads/master@{#379115}
==========

[commit-bot: I haz the power, 2016-03-03 22:29:22]

Patchset 2 (id:??) landed as
https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e
Cr-Commit-Position: refs/heads/master@{#379115}