Use VkPipelineCaches during VkPipeline creation

Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756493002

Committed: https://skia.googlesource.com/skia/+/03509eafa3e25819ff69f4d4f339d46264820c38

[jvanverth1, 2016-03-01 18:24:56]

Description was changed from

==========
Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
==========

to

==========
Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-01 18:25:53]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com

[jvanverth1, 2016-03-01 18:51:40]

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
File src/gpu/vk/GrVkResourceProvider.cpp (right):

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
src/gpu/vk/GrVkResourceProvider.cpp:136: }
On 2016/03/01 18:47:46, egdaniel wrote:
> the fact that this line is highlighted worries me...is there some line ending
> this going on?

git cl was complaining that the file had a missing EOL at the end, so I added
one. All line endings are Unix friendly, I checked.

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
src/gpu/vk/GrVkResourceProvider.h:73: VkPipelineCache fPipelineCache;
On 2016/03/01 18:47:46, egdaniel wrote:
> you need to destroy this guy at some point right?

No, no -- memory is infinite.

[jvanverth1, 2016-03-01 18:57:13]

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
src/gpu/vk/GrVkResourceProvider.h:73: VkPipelineCache fPipelineCache;
On 2016/03/01 18:51:40, jvanverth1 wrote:
> On 2016/03/01 18:47:46, egdaniel wrote:
> > you need to destroy this guy at some point right?
> 
> No, no -- memory is infinite.

Done.

[jvanverth1, 2016-03-01 20:29:52]

On 2016/03/01 18:57:13, jvanverth1 wrote:
>
https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
> File src/gpu/vk/GrVkResourceProvider.h (right):
> 
>
https://codereview.chromium.org/1756493002/diff/1/src/gpu/vk/GrVkResourceProv...
> src/gpu/vk/GrVkResourceProvider.h:73: VkPipelineCache fPipelineCache;
> On 2016/03/01 18:51:40, jvanverth1 wrote:
> > On 2016/03/01 18:47:46, egdaniel wrote:
> > > you need to destroy this guy at some point right?
> > 
> > No, no -- memory is infinite.
> 
> Done.

Updated to move destruction to destroyResources().

[egdaniel, 2016-03-01 20:37:20]

lgtm. Only possible change if you feel its worthwhile, should we set the
pipeline cache to VK_NULL_HANDLE (and in abandonResources as well), and then we
can assert it is such in dtor?

[jvanverth1, 2016-03-02 20:57:09]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-03-02 20:57:10]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1756493002/#ps60001
(title: "Fix mipmap issues")

[commit-bot: I haz the power, 2016-03-02 20:57:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756493002/60001

[jvanverth1, 2016-03-02 20:57:19]

On 2016/03/01 20:37:20, egdaniel wrote:
> lgtm. Only possible change if you feel its worthwhile, should we set the
> pipeline cache to VK_NULL_HANDLE (and in abandonResources as well), and then
we
> can assert it is such in dtor?

Done.

[jvanverth1, 2016-03-02 20:57:19]

On 2016/03/01 20:37:20, egdaniel wrote:
> lgtm. Only possible change if you feel its worthwhile, should we set the
> pipeline cache to VK_NULL_HANDLE (and in abandonResources as well), and then
we
> can assert it is such in dtor?

Done.

[commit-bot: I haz the power, 2016-03-02 20:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 20:59:32]

Try jobs failed on following builders:
  Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7...)

[jvanverth1, 2016-03-02 21:18:45]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-03-02 21:18:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756493002/60001

[commit-bot: I haz the power, 2016-03-02 21:19:49]

Description was changed from

==========
Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/03509eafa3e25819ff69f4d4f339d46264820c38
==========

[commit-bot: I haz the power, 2016-03-02 21:19:50]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/03509eafa3e25819ff69f4d4f339d46264820c38