Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1756443002: [NTP Snippets] Fetcher: remove |overwrite| param (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@snippets_expire
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Fetcher: remove |overwrite| param There's really no point to it, and this lets us simplify things a bit. BUG=587822 Committed: https://crrev.com/d8c3a33980dcfda6e3f622573be6ed5f14d597e0 Cr-Commit-Position: refs/heads/master@{#378478}

Patch Set 1 #

Patch Set 2 : fix test #

Messages

Total messages: 13 (6 generated)
Marc Treib
PTAL!
4 years, 9 months ago (2016-03-01 14:58:53 UTC) #2
Bernhard Bauer
lgtm
4 years, 9 months ago (2016-03-01 15:06:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756443002/1
4 years, 9 months ago (2016-03-01 16:14:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/29418)
4 years, 9 months ago (2016-03-01 16:30:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756443002/20001
4 years, 9 months ago (2016-03-01 16:56:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 18:07:39 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 18:09:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8c3a33980dcfda6e3f622573be6ed5f14d597e0
Cr-Commit-Position: refs/heads/master@{#378478}

Powered by Google App Engine
This is Rietveld 408576698