Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 1756443002: [NTP Snippets] Fetcher: remove |overwrite| param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_expire
Patch Set: fix test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp_snippets_controller.cc ('k') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h
index 2ae47ad8bdde9ac14b16154d8029b019634e518e..b56298f86ba9e26eeadfa7e05db0d1dbea77394b 100644
--- a/components/ntp_snippets/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/ntp_snippets_fetcher.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_
#define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_FETCHER_H_
+#include <string>
+
#include "base/callback.h"
#include "base/callback_list.h"
#include "base/files/file_path.h"
@@ -40,21 +42,17 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
const base::FilePath& base_download_path);
~NTPSnippetsFetcher() override;
- // Fetches snippets from the server. |overwrite| is true if existing snippets
- // should be overwritten.
- void FetchSnippets(bool overwrite);
-
- // Adds a callback that is called when a new set of snippets are downloaded
+ // Adds a callback that is called when a new set of snippets are downloaded.
scoped_ptr<SnippetsAvailableCallbackList::Subscription> AddCallback(
const SnippetsAvailableCallback& callback) WARN_UNUSED_RESULT;
+ // Fetches snippets from the server.
+ void FetchSnippets();
+
private:
void StartTokenRequest();
- void NotifyObservers();
- void OnDownloadSnippetsDone(bool success);
- void OnFileExistsCheckDone(bool exists);
void OnFileMoveDone(bool success);
- void StartFetch();
+ void NotifyObservers();
// OAuth2TokenService::Consumer overrides:
void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
« no previous file with comments | « chrome/browser/android/ntp_snippets_controller.cc ('k') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698