Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java

Issue 1756443002: [NTP Snippets] Fetcher: remove |overwrite| param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_expire
Patch Set: fix test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
index e11d187ee091141c778b8e74869c978ccd015fc8..28975a63650ae7157011cf3556e4b99fcb8e27a1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
@@ -13,7 +13,7 @@ import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
/**
- * The main controller for calling into the native snippets component to fetch snippets
+ * The main controller for calling into the native snippets component to fetch snippets.
*/
public class SnippetsController implements SignInStateObserver {
private static SnippetsController sInstance;
@@ -28,13 +28,10 @@ public class SnippetsController implements SignInStateObserver {
}
/**
- * Fetches new snippets
- *
- * @param overwrite true if an update to the current snippets should be forced, and false if
- * snippets should be downloaded only if there are no existing ones.
+ * Fetches new snippets.
*/
- public void fetchSnippets(boolean overwrite) {
- nativeFetchSnippets(Profile.getLastUsedProfile(), overwrite);
+ public void fetchSnippets() {
+ nativeFetchSnippets(Profile.getLastUsedProfile());
}
/**
@@ -53,7 +50,7 @@ public class SnippetsController implements SignInStateObserver {
@Override
public void onSignedIn() {
- fetchSnippets(true);
+ fetchSnippets();
}
@Override
@@ -64,5 +61,5 @@ public class SnippetsController implements SignInStateObserver {
sInstance = instance;
}
- private native void nativeFetchSnippets(Profile profile, boolean overwrite);
+ private native void nativeFetchSnippets(Profile profile);
}

Powered by Google App Engine
This is Rietveld 408576698