Implement various vulkan stencil clears and fix various stenciling bugs.

Implement various vulkan stencil clears and fix various stenciling bugs.

BUG=skia:4973
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755753002

Committed: https://skia.googlesource.com/skia/+/3d5d9ac426ea926f37eaa47e13acf7492068667b

[egdaniel, 2016-03-01 18:14:04]

Description was changed from

==========
Implement various vulkan stencil clears and fix various stenciling bugs.

BUG=skia:4973
==========

to

==========
Implement various vulkan stencil clears and fix various stenciling bugs.

BUG=skia:4973
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-03-01 18:31:21]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[jvanverth1, 2016-03-01 18:49:10]

lgtm + comments

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:297: void
GrVkCommandBuffer::clearStencilImage(const GrVkGpu* gpu,
We will probably add a depth buffer at some point, so it might be more accurate
to call this clearDepthStencilImage (since it could be used for either/both).

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:945: // The contract with the callers does not guarrante
that we preserve all bits in the stencil
guarantee

[egdaniel, 2016-03-01 20:25:53]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-03-01 20:25:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1755753002/#ps40001
(title: "Review Nits")

[commit-bot: I haz the power, 2016-03-01 20:25:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755753002/40001

[egdaniel, 2016-03-01 20:34:38]

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:297: void
GrVkCommandBuffer::clearStencilImage(const GrVkGpu* gpu,
On 2016/03/01 18:49:10, jvanverth1 wrote:
> We will probably add a depth buffer at some point, so it might be more
accurate
> to call this clearDepthStencilImage (since it could be used for either/both).

Done.

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1755753002/diff/20001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:945: // The contract with the callers does not guarrante
that we preserve all bits in the stencil
On 2016/03/01 18:49:10, jvanverth1 wrote:
> guarantee

Done.

[commit-bot: I haz the power, 2016-03-01 20:56:17]

Description was changed from

==========
Implement various vulkan stencil clears and fix various stenciling bugs.

BUG=skia:4973
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Implement various vulkan stencil clears and fix various stenciling bugs.

BUG=skia:4973
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3d5d9ac426ea926f37eaa47e13acf7492068667b
==========

[commit-bot: I haz the power, 2016-03-01 20:56:18]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3d5d9ac426ea926f37eaa47e13acf7492068667b