src/gpu/vk/GrVkRenderPass.cpp - Issue 1755753002: Implement various vulkan stencil clears and fix various stenciling bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkRenderPass.cpp

Issue 1755753002: Implement various vulkan stencil clears and fix various stenciling bugs. (Closed) Base URL: https://skia.googlesource.com/skia.git@stencilImage

Patch Set: Review Nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/vk/GrVkRenderPass.cpp

diff --git a/src/gpu/vk/GrVkRenderPass.cpp b/src/gpu/vk/GrVkRenderPass.cpp

index 9c4787b865cb3bce8ef6e271e37bfd5d9931357d..958d604f546c658a502ee4670a2a4f22f8d37512 100644

--- a/src/gpu/vk/GrVkRenderPass.cpp

+++ b/src/gpu/vk/GrVkRenderPass.cpp

@@ -22,7 +22,7 @@ void setup_simple_vk_attachment_description(VkAttachmentDescription* attachment,

attachment->loadOp = VK_ATTACHMENT_LOAD_OP_LOAD;

attachment->storeOp = VK_ATTACHMENT_STORE_OP_STORE;

attachment->stencilLoadOp = VK_ATTACHMENT_LOAD_OP_LOAD;

- attachment->storeOp = VK_ATTACHMENT_STORE_OP_STORE;

+ attachment->stencilStoreOp = VK_ATTACHMENT_STORE_OP_STORE;

attachment->initialLayout = layout;

attachment->finalLayout = layout;

}

« no previous file with comments | « src/gpu/vk/GrVkPipeline.cpp ('k') | src/gpu/vk/GrVkRenderTarget.cpp » ('j') | no next file with comments »