Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID)

Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID) (patchset #17 id:320001 of https://codereview.chromium.org/1661423002/ )

Reason for revert:
The android tree auto closed.  I don't see which CL
is causing the trouble, so this is a guess.

Here are some logs from https://build.chromium.org/p/chromium/builders/Android/builds/52518

[6697/26456] CXX obj/third_party/skia/src/effects/skia_library.SkPackBits.o
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
[6698/26456] STAMP obj/third_party/junit/junit_jar.actions_rules_copies.stamp
[6699/26456] STAMP obj/third_party/mockito/mockito_jar.actions_depends.stamp
[6700/26456] ACTION Compiling mockito_jar java sources
FAILED: cd ../../ui/accessibility; python ../../build/android/gyp/lint.py "--lint-path=/b/build/slave/Android/build/src/third_party/android_tools/sdk//tools/lint" "--config-path=../../build/android/lint/suppressions.xml" "--processed-config-path=../../out/Release/gen/ui_accessibility_java/lint_config.xml" "--manifest-path=../../build/android/AndroidManifest.xml" "--result-path=../../out/Release/gen/ui_accessibility_java/lint_result.xml" "--resource-dir=../../build/android/ant/empty/res" "--product-dir=../../out/Release" "--src-dirs=../../build/android/empty/src" "--jar-path=../../out/Release/lib.java/ui_accessibility_java.jar" --can-fail-build "--stamp=../../out/Release/gen/ui_accessibility_java/lint.stamp" --enable
Lint created unparseable xml file...
File contents:

Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 231, in <module>
    sys.exit(main())
  File "../../build/android/gyp/lint.py", line 227, in main
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 513, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 500, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/lint.py", line 222, in <lambda>
    can_fail_build=options.can_fail_build),
  File "../../build/android/gyp/lint.py", line 136, in _OnStaleMd5
    num_issues = _ParseAndShowResultFile()
  File "../../build/android/gyp/lint.py", line 54, in _ParseAndShowResultFile
    dom = minidom.parse(result_path)
  File "/usr/lib/python2.7/xml/dom/minidom.py", line 1920, in parse
    return expatbuilder.parse(file)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 924, in parse
    result = builder.parseFile(fp)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 211, in parseFile
    parser.Parse("", True)
xml.parsers.expat.ExpatError: no element found: line 1, column 0
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
ninja: build stopped: subcommand failed.


Original issue's description:
> This patch gives the NavigationHandle a NavigationEntry on instantiation, so it can know the entry's unique id. This id is used to for detecting mismatch on DidFailProvisionalLoad, so if the current handle does not match the pending entry, we won't discard it.
> 
> We also use the handle's new entry id to more securely restrict cloning entries in NavigationCOntrollerImpl::RendererDidNavigateToNewPage.
> 
> BUG=513742
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/9a9142bc4afafb16c2245ec30d018b0089e2d20f
> Cr-Commit-Position: refs/heads/master@{#378463}

TBR=bauerb@chromium.org,boliu@chromium.org,clamy@chromium.org,creis@chromium.org,mnaganov@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513742

[dschuyler, 2016-03-01 18:01:06]

Created Revert of Solidify Entry discarding logic (NavigationHandle keeps its
ID)

[boliu, 2016-03-01 18:01:35]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2016-03-01 18:01:46]

Are you sure this is the cause?

[boliu, 2016-03-01 18:02:12]

On 2016/03/01 18:01:46, boliu wrote:
> Are you sure this is the cause?

It was a flake. Next run is already green

[boliu, 2016-03-01 18:02:21]

Description was changed from

==========
Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID)
(patchset #17 id:320001 of https://codereview.chromium.org/1661423002/ )

Reason for revert:
The android tree auto closed.  I don't see which CL
is causing the trouble, so this is a guess.

Here are some logs from
https://build.chromium.org/p/chromium/builders/Android/builds/52518

[6697/26456] CXX obj/third_party/skia/src/effects/skia_library.SkPackBits.o
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
[6698/26456] STAMP obj/third_party/junit/junit_jar.actions_rules_copies.stamp
[6699/26456] STAMP obj/third_party/mockito/mockito_jar.actions_depends.stamp
[6700/26456] ACTION Compiling mockito_jar java sources
FAILED: cd ../../ui/accessibility; python ../../build/android/gyp/lint.py
"--lint-path=/b/build/slave/Android/build/src/third_party/android_tools/sdk//tools/lint"
"--config-path=../../build/android/lint/suppressions.xml"
"--processed-config-path=../../out/Release/gen/ui_accessibility_java/lint_config.xml"
"--manifest-path=../../build/android/AndroidManifest.xml"
"--result-path=../../out/Release/gen/ui_accessibility_java/lint_result.xml"
"--resource-dir=../../build/android/ant/empty/res"
"--product-dir=../../out/Release" "--src-dirs=../../build/android/empty/src"
"--jar-path=../../out/Release/lib.java/ui_accessibility_java.jar"
--can-fail-build
"--stamp=../../out/Release/gen/ui_accessibility_java/lint.stamp" --enable
Lint created unparseable xml file...
File contents:

Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 231, in <module>
    sys.exit(main())
  File "../../build/android/gyp/lint.py", line 227, in main
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 513, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 500, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/lint.py", line 222, in <lambda>
    can_fail_build=options.can_fail_build),
  File "../../build/android/gyp/lint.py", line 136, in _OnStaleMd5
    num_issues = _ParseAndShowResultFile()
  File "../../build/android/gyp/lint.py", line 54, in _ParseAndShowResultFile
    dom = minidom.parse(result_path)
  File "/usr/lib/python2.7/xml/dom/minidom.py", line 1920, in parse
    return expatbuilder.parse(file)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 924, in parse
    result = builder.parseFile(fp)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 211, in parseFile
    parser.Parse("", True)
xml.parsers.expat.ExpatError: no element found: line 1, column 0
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
ninja: build stopped: subcommand failed.


Original issue's description:
> This patch gives the NavigationHandle a NavigationEntry on instantiation, so
it can know the entry's unique id. This id is used to for detecting mismatch on
DidFailProvisionalLoad, so if the current handle does not match the pending
entry, we won't discard it.
> 
> We also use the handle's new entry id to more securely restrict cloning
entries in NavigationCOntrollerImpl::RendererDidNavigateToNewPage.
> 
> BUG=513742
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/9a9142bc4afafb16c2245ec30d018b0089e2d20f
> Cr-Commit-Position: refs/heads/master@{#378463}

TBR=bauerb@chromium.org,boliu@chromium.org,clamy@chromium.org,creis@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513742
==========

to

==========
Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID)
(patchset #17 id:320001 of https://codereview.chromium.org/1661423002/ )

Reason for revert:
The android tree auto closed.  I don't see which CL
is causing the trouble, so this is a guess.

Here are some logs from
https://build.chromium.org/p/chromium/builders/Android/builds/52518

[6697/26456] CXX obj/third_party/skia/src/effects/skia_library.SkPackBits.o
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
[6698/26456] STAMP obj/third_party/junit/junit_jar.actions_rules_copies.stamp
[6699/26456] STAMP obj/third_party/mockito/mockito_jar.actions_depends.stamp
[6700/26456] ACTION Compiling mockito_jar java sources
FAILED: cd ../../ui/accessibility; python ../../build/android/gyp/lint.py
"--lint-path=/b/build/slave/Android/build/src/third_party/android_tools/sdk//tools/lint"
"--config-path=../../build/android/lint/suppressions.xml"
"--processed-config-path=../../out/Release/gen/ui_accessibility_java/lint_config.xml"
"--manifest-path=../../build/android/AndroidManifest.xml"
"--result-path=../../out/Release/gen/ui_accessibility_java/lint_result.xml"
"--resource-dir=../../build/android/ant/empty/res"
"--product-dir=../../out/Release" "--src-dirs=../../build/android/empty/src"
"--jar-path=../../out/Release/lib.java/ui_accessibility_java.jar"
--can-fail-build
"--stamp=../../out/Release/gen/ui_accessibility_java/lint.stamp" --enable
Lint created unparseable xml file...
File contents:

Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 231, in <module>
    sys.exit(main())
  File "../../build/android/gyp/lint.py", line 227, in main
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 513, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 500, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/lint.py", line 222, in <lambda>
    can_fail_build=options.can_fail_build),
  File "../../build/android/gyp/lint.py", line 136, in _OnStaleMd5
    num_issues = _ParseAndShowResultFile()
  File "../../build/android/gyp/lint.py", line 54, in _ParseAndShowResultFile
    dom = minidom.parse(result_path)
  File "/usr/lib/python2.7/xml/dom/minidom.py", line 1920, in parse
    return expatbuilder.parse(file)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 924, in parse
    result = builder.parseFile(fp)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 211, in parseFile
    parser.Parse("", True)
xml.parsers.expat.ExpatError: no element found: line 1, column 0
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
ninja: build stopped: subcommand failed.


Original issue's description:
> This patch gives the NavigationHandle a NavigationEntry on instantiation, so
it can know the entry's unique id. This id is used to for detecting mismatch on
DidFailProvisionalLoad, so if the current handle does not match the pending
entry, we won't discard it.
> 
> We also use the handle's new entry id to more securely restrict cloning
entries in NavigationCOntrollerImpl::RendererDidNavigateToNewPage.
> 
> BUG=513742
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/9a9142bc4afafb16c2245ec30d018b0089e2d20f
> Cr-Commit-Position: refs/heads/master@{#378463}

TBR=bauerb@chromium.org,boliu@chromium.org,clamy@chromium.org,creis@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513742
==========

[dschuyler, 2016-03-01 18:11:31]

On 2016/03/01 18:02:12, boliu wrote:
> On 2016/03/01 18:01:46, boliu wrote:
> > Are you sure this is the cause?
> 
> It was a flake. Next run is already green

Thanks!