Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3310)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

Issue 1755733002: Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
index ea3efeacf8d71277ad48ebbf0a9aeb61978e21fc..2a54f7fe14536627973fc33f32dbc6a56b993ab1 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
@@ -135,19 +135,15 @@
EXPECT_EQ(GURL("chrome://settings/contentExceptions#media-stream-mic"),
GetActiveTab()->GetLastCommittedURL());
+ // The camera bubble links to camera exceptions.
+ ManageMediaStreamSettings(TabSpecificContentSettings::CAMERA_ACCESSED);
+ EXPECT_EQ(GURL("chrome://settings/contentExceptions#media-stream-camera"),
+ GetActiveTab()->GetLastCommittedURL());
+
// The bubble for both media devices links to the the first section of the
// default media content settings, which is the microphone section.
ManageMediaStreamSettings(TabSpecificContentSettings::MICROPHONE_ACCESSED |
TabSpecificContentSettings::CAMERA_ACCESSED);
EXPECT_EQ(GURL("chrome://settings/content#media-stream-mic"),
GetActiveTab()->GetLastCommittedURL());
-
- // In ChromeOS, we do not sanitize chrome://settings-frame to
- // chrome://settings for same-document navigations. See crbug.com/416157. For
- // this reason, order the tests so no same-document navigation occurs.
-
- // The camera bubble links to camera exceptions.
- ManageMediaStreamSettings(TabSpecificContentSettings::CAMERA_ACCESSED);
- EXPECT_EQ(GURL("chrome://settings/contentExceptions#media-stream-camera"),
- GetActiveTab()->GetLastCommittedURL());
}
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698