Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: content/browser/frame_host/navigation_request.cc

Issue 1755733002: Revert of Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigation_request.h" 5 #include "content/browser/frame_host/navigation_request.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "content/browser/frame_host/frame_tree.h" 9 #include "content/browser/frame_host/frame_tree.h"
10 #include "content/browser/frame_host/frame_tree_node.h" 10 #include "content/browser/frame_host/frame_tree_node.h"
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 return; 220 return;
221 } 221 }
222 222
223 // There is no need to make a network request for this navigation, so commit 223 // There is no need to make a network request for this navigation, so commit
224 // it immediately. 224 // it immediately.
225 state_ = RESPONSE_STARTED; 225 state_ = RESPONSE_STARTED;
226 frame_tree_node_->navigator()->CommitNavigation( 226 frame_tree_node_->navigator()->CommitNavigation(
227 frame_tree_node_, nullptr, scoped_ptr<StreamHandle>()); 227 frame_tree_node_, nullptr, scoped_ptr<StreamHandle>());
228 } 228 }
229 229
230 void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) { 230 void NavigationRequest::CreateNavigationHandle() {
231 // TODO(nasko): Update the NavigationHandle creation to ensure that the 231 // TODO(nasko): Update the NavigationHandle creation to ensure that the
232 // proper values are specified for is_synchronous and is_srcdoc. 232 // proper values are specified for is_synchronous and is_srcdoc.
233 navigation_handle_ = NavigationHandleImpl::Create( 233 navigation_handle_ =
234 common_params_.url, frame_tree_node_, 234 NavigationHandleImpl::Create(common_params_.url, frame_tree_node_,
235 false, // is_synchronous 235 false, // is_synchronous
236 false, // is_srcdoc 236 false, // is_srcdoc
237 common_params_.navigation_start, pending_nav_entry_id); 237 common_params_.navigation_start);
238 } 238 }
239 239
240 void NavigationRequest::TransferNavigationHandleOwnership( 240 void NavigationRequest::TransferNavigationHandleOwnership(
241 RenderFrameHostImpl* render_frame_host) { 241 RenderFrameHostImpl* render_frame_host) {
242 render_frame_host->SetNavigationHandle(std::move(navigation_handle_)); 242 render_frame_host->SetNavigationHandle(std::move(navigation_handle_));
243 } 243 }
244 244
245 void NavigationRequest::OnRequestRedirected( 245 void NavigationRequest::OnRequestRedirected(
246 const net::RedirectInfo& redirect_info, 246 const net::RedirectInfo& redirect_info,
247 const scoped_refptr<ResourceResponse>& response) { 247 const scoped_refptr<ResourceResponse>& response) {
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 browser_context, navigating_frame_host->GetSiteInstance()); 365 browser_context, navigating_frame_host->GetSiteInstance());
366 DCHECK(partition); 366 DCHECK(partition);
367 367
368 ServiceWorkerContextWrapper* service_worker_context = 368 ServiceWorkerContextWrapper* service_worker_context =
369 static_cast<ServiceWorkerContextWrapper*>( 369 static_cast<ServiceWorkerContextWrapper*>(
370 partition->GetServiceWorkerContext()); 370 partition->GetServiceWorkerContext());
371 navigation_handle_->InitServiceWorkerHandle(service_worker_context); 371 navigation_handle_->InitServiceWorkerHandle(service_worker_context);
372 } 372 }
373 373
374 } // namespace content 374 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698