Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5168)

Unified Diff: chrome/browser/media/media_browsertest.cc

Issue 1755403002: Do not change the case of titles in Utils.setResultInTitle(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow CDM crash tests to pass. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/test/data/eme_player_js/utils.js » ('j') | media/test/data/eme_player_js/utils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/media_browsertest.cc
diff --git a/chrome/browser/media/media_browsertest.cc b/chrome/browser/media/media_browsertest.cc
index 79eb35c50218899b73101e1fc6c593c462289651..d02f75263b96923d8de0cb63726f2407883b8552 100644
--- a/chrome/browser/media/media_browsertest.cc
+++ b/chrome/browser/media/media_browsertest.cc
@@ -17,11 +17,16 @@
#include "media/base/test_data_util.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
-// Common test results.
-const char MediaBrowserTest::kEnded[] = "ENDED";
-const char MediaBrowserTest::kError[] = "ERROR";
+// Normal failure title.
const char MediaBrowserTest::kFailed[] = "FAILED";
+// Capitalized event name set by Utils.installTitleEventHandler().
+const char MediaBrowserTest::kEnded[] = "ENDED";
ddorwin 2016/03/04 19:00:16 Should we make this more unique as well? "TEST_END
sandersd (OOO until July 31) 2016/03/04 19:26:00 We certainly should. I've filed a bug to track the
ddorwin 2016/03/04 20:14:06 FTR, https://bugs.chromium.org/p/chromium/issues/d
ddorwin 2016/03/04 20:14:06 Perhaps this should be kEndedEvent to make it clea
sandersd (OOO until July 31) 2016/03/04 20:40:17 I'm not certain that it is always used to mean tha
+
+// Uncapitalized event name as set by Utils.failTest().
+// TODO(sandersd): Change the tests to use a more unique message.
+const char MediaBrowserTest::kError[] = "error";
+
MediaBrowserTest::MediaBrowserTest() : ignore_plugin_crash_(false) {}
MediaBrowserTest::~MediaBrowserTest() {}
« no previous file with comments | « no previous file | media/test/data/eme_player_js/utils.js » ('j') | media/test/data/eme_player_js/utils.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698