Chromium Code Reviews| Index: chrome/browser/media/media_browsertest.cc |
| diff --git a/chrome/browser/media/media_browsertest.cc b/chrome/browser/media/media_browsertest.cc |
| index 79eb35c50218899b73101e1fc6c593c462289651..d02f75263b96923d8de0cb63726f2407883b8552 100644 |
| --- a/chrome/browser/media/media_browsertest.cc |
| +++ b/chrome/browser/media/media_browsertest.cc |
| @@ -17,11 +17,16 @@ |
| #include "media/base/test_data_util.h" |
| #include "net/test/embedded_test_server/embedded_test_server.h" |
| -// Common test results. |
| -const char MediaBrowserTest::kEnded[] = "ENDED"; |
| -const char MediaBrowserTest::kError[] = "ERROR"; |
| +// Normal failure title. |
| const char MediaBrowserTest::kFailed[] = "FAILED"; |
| +// Capitalized event name set by Utils.installTitleEventHandler(). |
| +const char MediaBrowserTest::kEnded[] = "ENDED"; |
|
ddorwin
2016/03/04 19:00:16
Should we make this more unique as well? "TEST_END
sandersd (OOO until July 31)
2016/03/04 19:26:00
We certainly should. I've filed a bug to track the
ddorwin
2016/03/04 20:14:06
FTR, https://bugs.chromium.org/p/chromium/issues/d
ddorwin
2016/03/04 20:14:06
Perhaps this should be kEndedEvent to make it clea
sandersd (OOO until July 31)
2016/03/04 20:40:17
I'm not certain that it is always used to mean tha
|
| + |
| +// Uncapitalized event name as set by Utils.failTest(). |
| +// TODO(sandersd): Change the tests to use a more unique message. |
| +const char MediaBrowserTest::kError[] = "error"; |
| + |
| MediaBrowserTest::MediaBrowserTest() : ignore_plugin_crash_(false) {} |
| MediaBrowserTest::~MediaBrowserTest() {} |