Do not change the case of titles in Utils.setResultInTitle().

chrome/browser/media/media_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/media_browsertest.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "media/base/test_data_util.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
-// Common test results.
+// Normal failure title.
+const char MediaBrowserTest::kFailed[] = "FAILED";
+
+// Capitalized event name set by Utils.installTitleEventHandler().
 const char MediaBrowserTest::kEnded[] = "ENDED";

[ddorwin, 2016/03/04 19:00:16]

Should we make this more unique as well? "TEST_ENDED/COMPLETE" or something?

[sandersd (OOO until July 31), 2016/03/04 19:26:00]

We certainly should. I've filed a bug to track these changes.

[ddorwin, 2016/03/04 20:14:06]

FTR, https://bugs.chromium.org/p/chromium/issues/detail?id=592067

[ddorwin, 2016/03/04 20:14:06]

Perhaps this should be kEndedEvent to make it clear that we are talking about a
JS event.

[sandersd (OOO until July 31), 2016/03/04 20:40:17]

I'm not certain that it is always used to mean that. It is for the specific
MSE+EME tests I was looking at, but there are others here I am less sure about.
I expect that any refactoring as requested in the bug will improve this.

-const char MediaBrowserTest::kError[] = "ERROR";
-const char MediaBrowserTest::kFailed[] = "FAILED";
+
+// Uncapitalized event name as set by Utils.failTest().
+// TODO(sandersd): Change the tests to use a more unique message.
+const char MediaBrowserTest::kError[] = "error";
 
 MediaBrowserTest::MediaBrowserTest() : ignore_plugin_crash_(false) {}
 
 MediaBrowserTest::~MediaBrowserTest() {}
 
 void MediaBrowserTest::RunMediaTestPage(const std::string& html_page,
                                         const base::StringPairs& query_params,
                                         const std::string& expected_title,
                                         bool http) {
   GURL gurl;
@@ skipping 39 matching lines @@
                                      base::ProcessId plugin_pid) {
   DVLOG(0) << "Plugin crashed: " << plugin_path.value();
   if (ignore_plugin_crash_)
     return;
   ADD_FAILURE() << "Failing test due to plugin crash.";
 }
 
 void MediaBrowserTest::IgnorePluginCrash() {
   ignore_plugin_crash_ = true;
 }