Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: media/test/data/eme_player_js/utils.js

Issue 1755403002: Do not change the case of titles in Utils.setResultInTitle(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow CDM crash tests to pass. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/test/data/eme_player_js/utils.js
diff --git a/media/test/data/eme_player_js/utils.js b/media/test/data/eme_player_js/utils.js
index 8ebb033f71f13fe7d66490f2612f17f7665c6528..7eec1bdb4dd0124d0b76e14d8319728e45a0bef5 100644
--- a/media/test/data/eme_player_js/utils.js
+++ b/media/test/data/eme_player_js/utils.js
@@ -181,7 +181,7 @@ Utils.hasPrefix = function(msg, prefix) {
Utils.installTitleEventHandler = function(element, event) {
element.addEventListener(event, function(e) {
- Utils.setResultInTitle(e.type);
+ Utils.setResultInTitle(e.type.toUpperCase());
ddorwin 2016/03/04 19:00:16 There is an "ended" event that would conflict with
sandersd (OOO until July 31) 2016/03/04 19:26:00 Indeed there is, but tests are explicitly relying
ddorwin 2016/03/04 20:14:06 Hmm. Maybe all the expected strings should have sp
sandersd (OOO until July 31) 2016/03/04 20:40:17 Acknowledged.
}, false);
};
@@ -256,8 +256,8 @@ Utils.sendRequest = function(
Utils.setResultInTitle = function(title) {
// If document title is 'ENDED', then update it with new title to possibly
// mark a test as failure. Otherwise, keep the first title change in place.
- if (!this.titleChanged || document.title.toUpperCase() == 'ENDED')
- document.title = title.toUpperCase();
+ if (!this.titleChanged || document.title == 'ENDED')
+ document.title = title;
Utils.timeLog('Set document title to: ' + title + ', updated title: ' +
document.title);
this.titleChanged = true;
« chrome/browser/media/media_browsertest.cc ('K') | « chrome/browser/media/media_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698