Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1755333002: Subzero. ARM32. Fixes bugs uncovered by the llvm test suite. (Closed)

Created:
4 years, 9 months ago by John
Modified:
4 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make format; adds more lit tests (arm 64 bit) #

Total comments: 3

Patch Set 3 : Addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -60 lines) Patch
M src/IceInstARM32.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 7 chunks +21 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 6 chunks +74 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 1 chunk +26 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 20 chunks +110 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
John
https://codereview.chromium.org/1755333002/diff/20001/tests_lit/llvm2ice_tests/vector-bitcast.ll File tests_lit/llvm2ice_tests/vector-bitcast.ll (left): https://codereview.chromium.org/1755333002/diff/20001/tests_lit/llvm2ice_tests/vector-bitcast.ll#oldcode163 tests_lit/llvm2ice_tests/vector-bitcast.ll:163: ; OPMT1: call -4 typo... only found this out ...
4 years, 9 months ago (2016-03-02 21:38:59 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/1755333002/diff/20001/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1755333002/diff/20001/src/IceTargetLoweringARM32.h#newcode328 src/IceTargetLoweringARM32.h:328: Context.insert<InstFakeUse>(Dest); Optional. This pattern might be more self-documenting like ...
4 years, 9 months ago (2016-03-02 22:58:30 UTC) #3
Jim Stichnoth
lgtm
4 years, 9 months ago (2016-03-02 22:58:36 UTC) #4
John
https://codereview.chromium.org/1755333002/diff/20001/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1755333002/diff/20001/src/IceTargetLoweringARM32.h#newcode328 src/IceTargetLoweringARM32.h:328: Context.insert<InstFakeUse>(Dest); On 2016/03/02 22:58:30, stichnot wrote: > Optional. This ...
4 years, 9 months ago (2016-03-02 23:02:44 UTC) #5
John
4 years, 9 months ago (2016-03-02 23:10:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7e6aa5a164fdfd306708187529e856b0ed00741c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698