Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/IceInstARM32.cpp

Issue 1755333002: Subzero. ARM32. Fixes bugs uncovered by the llvm test suite. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index a0efcbd2eb38cf1999443300888289c8301d31f8..3c47ccc366bf9d9c5005479b53e939439bb845a0 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1575,7 +1575,9 @@ void InstARM32Mov::emitIAS(const Cfg *Func) const {
case IceType_v4f32:
assert(CondARM32::isUnconditional(Cond) &&
"Moves on <4 x f32> must be unconditional!");
- assert(SrcTy == DestTy && "Mov on different vector types");
+ // Mov between different Src and Dest types is used for bitcasting vectors.
+ // We still want to make sure SrcTy is a vector type.
+ assert(isVectorType(SrcTy) && "Mov between vector and scalar.");
Asm->vorrq(Dest, Src0, Src0);
return;
}
« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698