Simplify AuthenticationMethod type and PIN hash handling.

Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698
Committed: https://crrev.com/3c7592464a581a96d3c92015c1ee3b878205880b
Cr-Commit-Position: refs/heads/master@{#379365}

[Sergey Ulanov, 2016-03-03 18:40:54]

Description was changed from

==========
Simplify AuthenticationMethod type.

Previously AuthenticationMethod was a class
==========

to

==========
Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced 
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain 
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698
==========

[Sergey Ulanov, 2016-03-03 18:40:54]

sergeyu@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Sergey Ulanov, 2016-03-03 18:41:08]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-03-03 18:46:01]

Patchset #1 (id:20001) has been deleted

[kelvinp, 2016-03-04 18:40:54]

lgtm

https://codereview.chromium.org/1755273003/diff/40001/remoting/protocol/negot...
File remoting/protocol/negotiating_client_authenticator.cc (right):

https://codereview.chromium.org/1755273003/diff/40001/remoting/protocol/negot...
remoting/protocol/negotiating_client_authenticator.cc:100: std::string
supported_methods;
Out of curiosity, why do we switch from stringstream to string here?

[Sergey Ulanov, 2016-03-04 20:48:51]

https://codereview.chromium.org/1755273003/diff/40001/remoting/protocol/negot...
File remoting/protocol/negotiating_client_authenticator.cc (right):

https://codereview.chromium.org/1755273003/diff/40001/remoting/protocol/negot...
remoting/protocol/negotiating_client_authenticator.cc:100: std::string
supported_methods;
On 2016/03/04 18:40:54, kelvinp wrote:
> Out of curiosity, why do we switch from stringstream to string here?

I don't know why thought it was a good idea when I wrote this code.
String append makes this code much clearer.

[Sergey Ulanov, 2016-03-04 20:49:02]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-04 20:50:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755273003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755273003/40001

[commit-bot: I haz the power, 2016-03-04 21:34:41]

Description was changed from

==========
Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced 
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain 
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698
==========

to

==========
Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced 
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain 
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698
==========

[commit-bot: I haz the power, 2016-03-04 21:34:41]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-03-04 21:35:34]

Description was changed from

==========
Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced 
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain 
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698
==========

to

==========
Simplify AuthenticationMethod type and PIN hash handling.

1 Previously AuthenticationMethod was a class. Replaced
  it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
  that passes around PIN hash.
3 If the host config contains PIN in plain text then now
  the host hashes it instead of using spake2_plain
  authenticator method. This means that spake2_hmac is
  always used for Me2Me even when the PIN is not hashed
  in the config.

This change will make it easier to add new authentication
methods.

BUG=589698

Committed: https://crrev.com/3c7592464a581a96d3c92015c1ee3b878205880b
Cr-Commit-Position: refs/heads/master@{#379365}
==========

[commit-bot: I haz the power, 2016-03-04 21:35:35]

Patchset 1 (id:??) landed as
https://crrev.com/3c7592464a581a96d3c92015c1ee3b878205880b
Cr-Commit-Position: refs/heads/master@{#379365}