|
Simplify AuthenticationMethod type and PIN hash handling.
1 Previously AuthenticationMethod was a class. Replaced
it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
that passes around PIN hash.
3 If the host config contains PIN in plain text then now
the host hashes it instead of using spake2_plain
authenticator method. This means that spake2_hmac is
always used for Me2Me even when the PIN is not hashed
in the config.
This change will make it easier to add new authentication
methods.
BUG= 589698
Committed: https://crrev.com/3c7592464a581a96d3c92015c1ee3b878205880b
Cr-Commit-Position: refs/heads/master@{#379365}
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+283 lines, -379 lines) |
Patch |
|
M |
remoting/client/jni/chromoting_jni_instance.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
remoting/client/plugin/chromoting_instance.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
remoting/host/pin_hash.h
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
remoting/host/pin_hash.cc
|
View
|
|
2 chunks |
+31 lines, -9 lines |
0 comments
|
Download
|
|
M |
remoting/host/remoting_me2me_host.cc
|
View
|
|
4 chunks |
+7 lines, -10 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/authentication_method.h
|
View
|
|
2 chunks |
+26 lines, -70 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/authentication_method.cc
|
View
|
|
2 chunks |
+35 lines, -109 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/it2me_host_authenticator_factory.h
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/it2me_host_authenticator_factory.cc
|
View
|
|
2 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/me2me_host_authenticator_factory.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/me2me_host_authenticator_factory.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/negotiating_authenticator_base.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/negotiating_authenticator_base.cc
|
View
|
|
3 chunks |
+7 lines, -11 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/negotiating_authenticator_unittest.cc
|
View
|
|
4 chunks |
+49 lines, -62 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/negotiating_client_authenticator.cc
|
View
|
|
7 chunks |
+21 lines, -19 lines |
2 comments
|
Download
|
|
M |
remoting/protocol/negotiating_host_authenticator.h
|
View
|
|
1 chunk |
+10 lines, -5 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/negotiating_host_authenticator.cc
|
View
|
|
8 chunks |
+36 lines, -23 lines |
0 comments
|
Download
|
|
M |
remoting/protocol/pairing_client_authenticator.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
remoting/test/host_info.cc
|
View
|
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
remoting/test/protocol_perftest.cc
|
View
|
|
4 chunks |
+10 lines, -9 lines |
0 comments
|
Download
|
|
M |
remoting/test/remote_host_info.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
remoting/test/test_chromoting_client_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 13 (7 generated)
|