remoting/client/jni/chromoting_jni_instance.cc - Issue 1755273003: Simplify AuthenticationMethod type and PIN hash handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/chromoting_jni_instance.cc

Issue 1755273003: Simplify AuthenticationMethod type and PIN hash handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/client/jni/chromoting_jni_instance.cc

diff --git a/remoting/client/jni/chromoting_jni_instance.cc b/remoting/client/jni/chromoting_jni_instance.cc

index 678db65d14a835f1ad5bda6b38104a26917fc70b..4902e17c3b47e1270a544032f599942ff610ad36 100644

--- a/remoting/client/jni/chromoting_jni_instance.cc

+++ b/remoting/client/jni/chromoting_jni_instance.cc

@@ -81,12 +81,12 @@ ChromotingJniInstance::ChromotingJniInstance(ChromotingJniRuntime* jni_runtime,

host_pubkey));

std::vector<protocol::AuthenticationMethod> auth_methods;

- auth_methods.push_back(protocol::AuthenticationMethod::Spake2Pair());

- auth_methods.push_back(protocol::AuthenticationMethod::Spake2(

- protocol::AuthenticationMethod::HMAC_SHA256));

- auth_methods.push_back(protocol::AuthenticationMethod::Spake2(

- protocol::AuthenticationMethod::NONE));

- auth_methods.push_back(protocol::AuthenticationMethod::ThirdParty());

+ auth_methods.push_back(protocol::AuthenticationMethod::THIRD_PARTY);

+ auth_methods.push_back(protocol::AuthenticationMethod::SPAKE2_PAIR);

+ auth_methods.push_back(

+ protocol::AuthenticationMethod::SPAKE2_SHARED_SECRET_HMAC);

+ auth_methods.push_back(

+ protocol::AuthenticationMethod::SPAKE2_SHARED_SECRET_PLAIN);

authenticator_.reset(new protocol::NegotiatingClientAuthenticator(

pairing_id, pairing_secret, host_id_,

« no previous file with comments | « no previous file | remoting/client/plugin/chromoting_instance.cc » ('j') | remoting/protocol/negotiating_client_authenticator.cc » ('J')