Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1753783004: NTP4: erase notification promo UI (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org, Robert Sesek, Marc Treib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP4: erase notification promo UI Follow up will remove C++ and bubble-related UI, they're just hairy. R=estade@chromium.org BUG=329637, 576772 Committed: https://crrev.com/f0ab39477320611b54247f5f3b946a014daa4dad Cr-Commit-Position: refs/heads/master@{#378598}

Patch Set 1 #

Patch Set 2 : 1 more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -267 lines) Patch
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 5 chunks +0 lines, -154 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.css View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 3 chunks +0 lines, -49 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 9 months ago (2016-03-01 20:46:28 UTC) #2
Evan Stade
lgtm
4 years, 9 months ago (2016-03-01 21:13:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753783004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753783004/20001
4 years, 9 months ago (2016-03-01 21:41:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 23:20:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 23:21:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0ab39477320611b54247f5f3b946a014daa4dad
Cr-Commit-Position: refs/heads/master@{#378598}

Powered by Google App Engine
This is Rietveld 408576698