Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1754183002: Rename BaseHeap to BaseArena (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename BaseHeap to BaseArena Rename BaseHeap to BaseArena so the distiction from Heap is clear. BUG=591606 Committed: https://crrev.com/dabce1df8fba05b62fddc37ecf76a32eae560214 Cr-Commit-Position: refs/heads/master@{#378971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -240 lines) Patch
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 2 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCDesign.md View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 9 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 11 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 36 chunks +53 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 8 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 17 chunks +65 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
keishi
Just the renaming part from https://codereview.chromium.org/1477023003/
4 years, 9 months ago (2016-03-02 12:01:30 UTC) #2
haraken
LGTM Please create a tracking bug and add the bug number to the CL description.
4 years, 9 months ago (2016-03-02 13:35:45 UTC) #3
keishi
On 2016/03/02 13:35:45, haraken wrote: > LGTM > > Please create a tracking bug and ...
4 years, 9 months ago (2016-03-03 04:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754183002/1
4 years, 9 months ago (2016-03-03 04:59:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 06:28:25 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 06:29:32 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dabce1df8fba05b62fddc37ecf76a32eae560214
Cr-Commit-Position: refs/heads/master@{#378971}

Powered by Google App Engine
This is Rietveld 408576698