third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h - Issue 1754183002: Rename BaseHeap to BaseArena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

Issue 1754183002: Rename BaseHeap to BaseArena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

index ef6341c0bfb7107c4b31fa439e68cea4091051a1..bc3d4977e91c71c2924f091f2457ce50f0b1ae45 100644

--- a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

+++ b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

@@ -34,7 +34,7 @@ protected:

// the dangling pointer.

// Release builds don't have the ASSERT, but it is OK because

// release builds will crash in the following header->isMarked()

- // because all the entries of the orphaned heaps are zapped.

+ // because all the entries of the orphaned arenas are zapped.

ASSERT(!pageFromObject(objectPointer)->orphaned());

if (header->isMarked())