Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1753903002: fission bitmapprocstate (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fission bitmapprocstate BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753903002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/05a5647efed7fcbcc5bd1efa445a6a3ab445a6c3

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : cleaner seperation #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : done #

Total comments: 6

Patch Set 8 : use real types instead of uint8_t, fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -252 lines) Patch
M src/core/SkBitmapProcShader.h View 1 2 3 4 5 chunks +2 lines, -23 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 3 4 5 6 3 chunks +128 lines, -118 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 2 3 4 5 6 7 5 chunks +38 lines, -27 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 2 3 4 5 6 7 16 chunks +72 lines, -67 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState_sample.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
reed1
wip -- prep work for rolling in new bitmap context
4 years, 9 months ago (2016-03-01 20:46:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753903002/40001
4 years, 9 months ago (2016-03-02 02:08:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 02:25:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753903002/80001
4 years, 9 months ago (2016-03-02 13:56:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753903002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753903002/120001
4 years, 9 months ago (2016-03-02 14:14:52 UTC) #12
herb_g
https://codereview.chromium.org/1753903002/diff/120001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/1753903002/diff/120001/src/core/SkBitmapProcState.cpp#newcode39 src/core/SkBitmapProcState.cpp:39: SkBitmapProcInfo::SkBitmapProcInfo(const SkBitmapProvider& provider, Line up params and below. https://codereview.chromium.org/1753903002/diff/120001/src/core/SkBitmapProcState.cpp#newcode219 ...
4 years, 9 months ago (2016-03-02 16:00:18 UTC) #13
reed1
https://codereview.chromium.org/1753903002/diff/120001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/1753903002/diff/120001/src/core/SkBitmapProcState.cpp#newcode39 src/core/SkBitmapProcState.cpp:39: SkBitmapProcInfo::SkBitmapProcInfo(const SkBitmapProvider& provider, On 2016/03/02 16:00:18, herb_g wrote: > ...
4 years, 9 months ago (2016-03-02 16:28:28 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753903002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753903002/140001
4 years, 9 months ago (2016-03-02 16:28:46 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 16:43:49 UTC) #21
herb_g
lgtm
4 years, 9 months ago (2016-03-02 17:46:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753903002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753903002/140001
4 years, 9 months ago (2016-03-02 17:48:07 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:49:06 UTC) #26
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/05a5647efed7fcbcc5bd1efa445a6a3ab445a6c3

Powered by Google App Engine
This is Rietveld 408576698