Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1753823002: Clone non-markup event listeners for <use> in a separate pass (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-useelm-shadowbuilder-cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clone non-markup event listeners for <use> in a separate pass This brings us closer to be able to use cloneNode(true) for the initial clone. BUG=589682 Committed: https://crrev.com/7273a218c1f0bc4bb51cb0f8b7f27177170b8e74 Cr-Commit-Position: refs/heads/master@{#378604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 5 chunks +12 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
fs
4 years, 9 months ago (2016-03-01 17:44:20 UTC) #2
pdr.
On 2016/03/01 at 17:44:20, fs wrote: > LGTM
4 years, 9 months ago (2016-03-01 18:38:17 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1754693002 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-01 19:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753823002/1
4 years, 9 months ago (2016-03-01 19:11:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/31601)
4 years, 9 months ago (2016-03-01 20:38:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753823002/1
4 years, 9 months ago (2016-03-01 20:48:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 23:37:46 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 23:38:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7273a218c1f0bc4bb51cb0f8b7f27177170b8e74
Cr-Commit-Position: refs/heads/master@{#378604}

Powered by Google App Engine
This is Rietveld 408576698