Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1753843002: Simplify SVGUseElement::expand* methods (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-useelm-shadowbuilder-cleanup-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SVGUseElement::expand* methods * Use Traversal<Type> helpers. * Start at the ShadowRoot. BUG=589682 Committed: https://crrev.com/4be596e3238541450fb75898eb2d2dd62b84d15c Cr-Commit-Position: refs/heads/master@{#378722}

Patch Set 1 #

Patch Set 2 : Non-Oilpan fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -40 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 8 chunks +18 lines, -38 lines 0 comments Download

Depends on Patchset:

Issue 1753823002 Patch 1

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-01 18:48:31 UTC) #2
pdr.
On 2016/03/01 at 18:48:31, fs wrote: > LGTM
4 years, 9 months ago (2016-03-01 22:24:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753843002/20001
4 years, 9 months ago (2016-03-02 08:38:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 10:41:07 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:43:00 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4be596e3238541450fb75898eb2d2dd62b84d15c
Cr-Commit-Position: refs/heads/master@{#378722}

Powered by Google App Engine
This is Rietveld 408576698