Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1754693002: Remove redundant check in SVGUseElement::buildShadowTree (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant check in SVGUseElement::buildShadowTree We already perform this check on |target| in all callers (the method itself and buildShadowAndInstanceTree), so this condition will never be true at this point. Remove it (replace with assert.) Since this gets rid of the only way for buildShadowTree to return false, change the return- type to 'void' and simplify accordingly. BUG=589682 Committed: https://crrev.com/c60a0e23cf1b1f656692ac49dbbf3aad45869722 Cr-Commit-Position: refs/heads/master@{#378504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 4 chunks +5 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-01 16:57:22 UTC) #2
pdr.
On 2016/03/01 at 16:57:22, fs wrote: > A++++ would review again LGTM
4 years, 9 months ago (2016-03-01 18:33:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754693002/1
4 years, 9 months ago (2016-03-01 18:58:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:08:11 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:09:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c60a0e23cf1b1f656692ac49dbbf3aad45869722
Cr-Commit-Position: refs/heads/master@{#378504}

Powered by Google App Engine
This is Rietveld 408576698