Suppress the clang warning "-Wdeprecated-declarations" for CSSM API calls.

crypto/cssm_init.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CRYPTO_CSSM_INIT_H_
 #define CRYPTO_CSSM_INIT_H_
 
 #include <Security/cssm.h>
 
 #include "base/macros.h"
@@ skipping 28 matching lines @@
 // Wrapper class for CSSM_DATA type. This should only be used when using the
 // CL/TP/CSP handles from above, since that's the only time we're guaranteed (or
 // supposed to be guaranteed) that our memory management functions will be used.
 // Apple's Sec* APIs manage their own memory so it shouldn't be used for those.
 // The constructor initializes data_ to zero and the destructor releases the
 // data properly.
 class ScopedCSSMData {
  public:
   ScopedCSSMData();
   ~ScopedCSSMData();
+// CSSM functions are deprecated as of OSX 10.7, but have no replacement.

[Ryan Sleevi, 2016/03/01 15:59:58]

A newline between 48/49 would be helpful for readability.

More generally, though, why doesn't this deprecation wrapping need to be moved
to line 19/20? The CSSM_CSP_HANDLE / CSSM_API_MEMORY_FUNCS / CSSM_RETURN are all
part of the same deprecated state. I'm assuming it's because OS X doesn't
support deprecating typedefs?

[erikchen, 2016/03/02 02:02:59]

It looks like C++14 introduces a deprecated attribute, which Clang has already
implemented. I wouldn't be surprised if Apple deprecated the typedefs sometime
in the future.
http://josephmansfield.uk/articles/marking-deprecated-c++14.html

I went ahead and moved the wrapping to line 14, which includes one extra
function, but happens to be immediately after a namespace declaration. I also
moved the #pragma pop right before the end of the namespace scope. This seems
cleaner to me. (Given that the scope of the #clang diagnostics is entirely
independent of C++ semantic scoping, it still seems reasonable to attempt to
match the two together).

+// https://bugs.chromium.org/p/chromium/issues/detail?id=590914#c1
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
   operator CSSM_DATA*() { return &data_; }
   CSSM_DATA* operator ->() { return &data_; }
 
  private:
   CSSM_DATA data_;
+#pragma clang diagnostic pop
 
   DISALLOW_COPY_AND_ASSIGN(ScopedCSSMData);
 };
 
 }  // namespace crypto
 
 #endif  // CRYPTO_CSSM_INIT_H_