Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/ui/search/instant_page.h

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Spacing fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_page.h
diff --git a/chrome/browser/ui/search/instant_page.h b/chrome/browser/ui/search/instant_page.h
index b67647bf32f5d54425b84d0783cddad513a69712..2301459430460d8ab15cfef76bfc0bcc2f8558dc 100644
--- a/chrome/browser/ui/search/instant_page.h
+++ b/chrome/browser/ui/search/instant_page.h
@@ -90,6 +90,8 @@ class InstantPage : public content::WebContentsObserver,
WindowOpenDisposition disposition,
bool is_search_type) = 0;
+ virtual void LogIframeHover(int pos) = 0;
beaudoin 2013/06/22 01:14:53 Please add a comment to indicate that this is used
annark1 2013/06/25 16:01:38 Done.
+
// Called when the SearchBox wants to delete a Most Visited item.
virtual void DeleteMostVisitedItem(const GURL& url) = 0;
@@ -269,6 +271,7 @@ class InstantPage : public content::WebContentsObserver,
content::PageTransition transition,
WindowOpenDisposition disposition,
bool is_search_type);
+ void OnSearchBoxLogIframeHover(int page_id, int pos);
beaudoin 2013/06/22 01:14:53 Same here, not sure you need the pos.
annark1 2013/06/25 16:01:38 Done.
void OnDeleteMostVisitedItem(int page_id, const GURL& url);
void OnUndoMostVisitedDeletion(int page_id, const GURL& url);
void OnUndoAllMostVisitedDeletions(int page_id);

Powered by Google App Engine
This is Rietveld 408576698