Log NTP hovers in 1993 clients

chrome/browser/ui/search/instant_page.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_
 #define CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 72 matching lines @@
     // Called when the page wants to navigate to |url|. Usually used by the
     // page to navigate to privileged destinations (e.g. chrome:// URLs) or to
     // navigate to URLs that are hidden from the page using Restricted IDs (rid
     // in the API).
     virtual void NavigateToURL(const content::WebContents* contents,
                                const GURL& url,
                                content::PageTransition transition,
                                WindowOpenDisposition disposition,
                                bool is_search_type) = 0;
 
+    virtual void LogIframeHover(int pos) = 0;

[beaudoin, 2013/06/22 01:14:53]

Please add a comment to indicate that this is used for UMA logging.

[annark1, 2013/06/25 16:01:38]

Done.

+
     // Called when the SearchBox wants to delete a Most Visited item.
     virtual void DeleteMostVisitedItem(const GURL& url) = 0;
 
     // Called when the SearchBox wants to undo a Most Visited deletion.
     virtual void UndoMostVisitedDeletion(const GURL& url) = 0;
 
     // Called when the SearchBox wants to undo all Most Visited deletions.
     virtual void UndoAllMostVisitedDeletions() = 0;
 
     // Called when the page fails to load for whatever reason.
@@ skipping 159 matching lines @@
                         const std::vector<InstantSuggestion>& suggestions);
   void OnShowInstantOverlay(int page_id,
                             int height,
                             InstantSizeUnits units);
   void OnFocusOmnibox(int page_id, OmniboxFocusState state);
   void OnSearchBoxNavigate(int page_id,
                            const GURL& url,
                            content::PageTransition transition,
                            WindowOpenDisposition disposition,
                            bool is_search_type);
+  void OnSearchBoxLogIframeHover(int page_id, int pos);

[beaudoin, 2013/06/22 01:14:53]

Same here, not sure you need the pos.

[annark1, 2013/06/25 16:01:38]

Done.

   void OnDeleteMostVisitedItem(int page_id, const GURL& url);
   void OnUndoMostVisitedDeletion(int page_id, const GURL& url);
   void OnUndoAllMostVisitedDeletions(int page_id);
 
   void ClearContents();
 
   Delegate* const delegate_;
   const std::string instant_url_;
 
   DISALLOW_COPY_AND_ASSIGN(InstantPage);
 };
 
 #endif  // CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_