Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8121)

Unified Diff: chrome/renderer/resources/extensions/searchbox_api.js

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Spacing fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index c4083c6bb481a1fd392a6fa54f17bbf646ec8e61..6a29a1ad37b6a696298e3ee6d39fb56e77a4a5ee 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -258,6 +258,8 @@ if (!chrome.embeddedSearch) {
native function UndoMostVisitedDeletion();
native function NavigateNewTabPage();
native function IsInputInProgress();
+ native function LogEvent();
+
beaudoin 2013/06/22 01:14:53 Remove blank line.
annark1 2013/06/25 16:01:38 Done.
function GetMostVisitedItemsWrapper() {
var mostVisitedItems = GetMostVisitedItems();
@@ -290,7 +292,12 @@ if (!chrome.embeddedSearch) {
};
this.navigateContentWindow = function(destination, disposition) {
NavigateNewTabPage(destination, disposition);
- }
+ };
+ // This method is restricted to chrome-search://most-visited pages by
+ // checking the invoking context's origin in searchbox_extension.cc.
+ this.logEvent = function(name, value, opt_boundary, opt_pos) {
+ LogEvent(name, value, opt_boundary, opt_pos);
+ };
beaudoin 2013/06/22 01:14:53 Please run this by Jered since you're changing the
this.onmostvisitedchange = null;
this.onthemechange = null;

Powered by Google App Engine
This is Rietveld 408576698