Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp

Issue 1752513002: Ignore deprecated declaration warnings in GTM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
diff --git a/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp b/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
index b8dea1945e3a114f4111d2ac9879e7cb9a531ebc..b375725d5a76c43f401742d071b6bdcb41cb95aa 100644
--- a/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
+++ b/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
@@ -23,6 +23,12 @@
'src/Foundation',
],
},
+ # GTM supports ancient iOS and OSX versions, so it's full of APIs that
+ # have been deprecated in more recent iOS and OSX versions. Ignore all
+ # deprecated-declarations warnings.
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wno-deprecated-declarations'],
+ },
'sources': [
'src/AddressBook/GTMABAddressBook.h',
'src/AddressBook/GTMABAddressBook.m',
@@ -219,12 +225,6 @@
['include', '^src/Foundation/GTMStringEncoding\\.m$'],
['include', '^src/iPhone/'],
],
- # TODO(crbug.com/569158): Suppresses warnings that are treated as
- # errors when minimum iOS version support is increased to iOS 9. This
- # should be removed once all deprecation violations have been fixed.
- 'xcode_settings': {
- 'WARNING_CFLAGS': ['-Wno-deprecated-declarations'],
- },
}],
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698