Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 175233002: Hide GrRRectEffect class from header (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Hide GrRRectEffect class from header Committed: http://code.google.com/p/skia/source/detail?r=13535

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove gm changes from CL #

Patch Set 4 : improve comment #

Total comments: 4

Patch Set 5 : Address Rob's comments #

Patch Set 6 : Save header and upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -92 lines) Patch
M src/gpu/effects/GrRRectEffect.h View 1 2 3 4 5 1 chunk +9 lines, -34 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 3 4 4 chunks +92 lines, -58 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
Code shuffle to hide GrRRectEffect in the cpp. I want to add some complexity to ...
6 years, 10 months ago (2014-02-21 14:35:29 UTC) #1
robertphillips
lgtm + 1 nit & 1 question. https://codereview.chromium.org/175233002/diff/70001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/175233002/diff/70001/src/gpu/effects/GrRRectEffect.cpp#newcode54 src/gpu/effects/GrRRectEffect.cpp:54: Move into ...
6 years, 10 months ago (2014-02-21 14:39:58 UTC) #2
bsalomon
https://codereview.chromium.org/175233002/diff/70001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/175233002/diff/70001/src/gpu/effects/GrRRectEffect.cpp#newcode54 src/gpu/effects/GrRRectEffect.cpp:54: On 2014/02/21 14:39:58, robertphillips wrote: > Move into the ...
6 years, 10 months ago (2014-02-21 15:36:20 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 15:36:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/175233002/170001
6 years, 10 months ago (2014-02-21 15:36:26 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 17:52:31 UTC) #6
Message was sent while issue was closed.
Change committed as 13535

Powered by Google App Engine
This is Rietveld 408576698