Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1752153002: Fixed Dictionary emitted as interface and dictionary conversion with a null map (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated to latest blink and fixed in integration #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +1 line, -1 line 1 comment Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
terry
Committed patchset #1 (id:1) manually as a61bd2f7b2e087ebb37475e290ad21ed3b585185 (presubmit successful).
4 years, 9 months ago (2016-03-01 23:44:00 UTC) #2
terry
Committed patchset #2 (id:20001) manually as 6aff6fb1ba5e3d3ad3c7b30fb06be370c3c52298 (presubmit successful).
4 years, 9 months ago (2016-03-01 23:55:23 UTC) #4
Jacob
4 years, 9 months ago (2016-03-01 23:58:29 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1752153002/diff/20001/sdk/lib/html/html_commo...
File sdk/lib/html/html_common/conversions_dartium.dart (right):

https://codereview.chromium.org/1752153002/diff/20001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:118: _ReturnedDictionary(Map
value): _values = value ? value != null : {};
I think the cases are reversed. Did you mean
_value = value != null ? value : {};

?

Powered by Google App Engine
This is Rietveld 408576698