Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/dom/scripts/generator.py

Issue 1752153002: Fixed Dictionary emitted as interface and dictionary conversion with a null map (Closed) Base URL: git@github.com:dart-lang/sdk.git@integration
Patch Set: Updated to latest blink and fixed in integration Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index a80847f81dfbfcf35fe9ee1f383327aad7e26b12..a5488b255af3f3d4bc049008f825d20c45decfa1 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -1264,6 +1264,9 @@ _idl_type_registry = monitored.Dict('generator._idl_type_registry', {
# TODO(vsm): This won't actually work until we convert the Map to
# a native JS Map for JS DOM.
'Dictionary': TypeData(clazz='Primitive', dart_type='Map'),
+ # TODO(terry): It's a dictionary but a very complex dictionary is multiple lists.
+ # Need to investigate a 1-off solution probably.
+ 'MediaKeySystemConfiguration': TypeData(clazz='Primitive', dart_type='Map'),
'DOMTimeStamp': TypeData(clazz='Primitive', dart_type='int', native_type='unsigned long long'),
'object': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue'),
'ObjectArray': TypeData(clazz='Primitive', dart_type='List'),
« sdk/lib/html/html_common/conversions_dartium.dart ('K') | « tools/deps/dartium.deps/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698