sdk/lib/html/html_common/conversions_dartium.dart - Issue 1752153002: Fixed Dictionary emitted as interface and dictionary conversion with a null map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/html_common/conversions_dartium.dart

Issue 1752153002: Fixed Dictionary emitted as interface and dictionary conversion with a null map (Closed) Base URL: git@github.com:dart-lang/sdk.git@integration

Patch Set: Updated to latest blink and fixed in integration Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/html/html_common/conversions_dartium.dart

diff --git a/sdk/lib/html/html_common/conversions_dartium.dart b/sdk/lib/html/html_common/conversions_dartium.dart

index 03b2d345b564287753c7ce392025129498a79c0b..371997d6f1c89bddfadaf3f241539e828287626c 100644

--- a/sdk/lib/html/html_common/conversions_dartium.dart

+++ b/sdk/lib/html/html_common/conversions_dartium.dart

@@ -115,7 +115,7 @@ class _ReturnedDictionary {

Map get toMap => _values;

- _ReturnedDictionary(Map value): _values = value;

+ _ReturnedDictionary(Map value): _values = value ? value != null : {};

Jacob 2016/03/01 23:58:29 I think the cases are reversed. Did you mean _valu

}

// Helper function to wrapped a returned dictionary from blink to a Dart looking

« no previous file with comments | « no previous file | tools/deps/dartium.deps/DEPS » ('j') | no next file with comments »