Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1751963003: Fix crash when --ll_prof is enabled after cb29f9c (Closed)

Created:
4 years, 9 months ago by rmcilroy
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Stefano Sanfilippo
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_profile_sourcepos
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix crash when --ll_prof is enabled after cb29f9c BUG=v8:4766 LOG=N Committed: https://crrev.com/39b47107a2998619050f15fdfcc702cf08d46ec1 Cr-Commit-Position: refs/heads/master@{#34446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/log.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1737043002 Patch 120001

Messages

Total messages: 12 (5 generated)
rmcilroy
PTAL, thanks.
4 years, 9 months ago (2016-03-02 06:25:17 UTC) #2
Yang
On 2016/03/02 06:25:17, rmcilroy (Slow - Traveling) wrote: > PTAL, thanks. lgtm.
4 years, 9 months ago (2016-03-02 06:29:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751963003/1
4 years, 9 months ago (2016-03-02 19:32:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/16232)
4 years, 9 months ago (2016-03-02 19:39:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751963003/1
4 years, 9 months ago (2016-03-02 19:54:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 20:10:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 20:11:44 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39b47107a2998619050f15fdfcc702cf08d46ec1
Cr-Commit-Position: refs/heads/master@{#34446}

Powered by Google App Engine
This is Rietveld 408576698