Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1737043002: [Interpreter] Log source positions for bytecode arrays. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_cpu_profiler
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Log source positions for bytecode arrays. Add support to log source position offsets to the profiler. As part of this change PositionsRecorder is split into two, with the subset needed by log.cc moved into log.h and the remainder kept in assembler.h as AssemblerPositionsRecorder. The interpreter's source position table builder is updated to log positions when the profiler is active. BUG=v8:4766 LOG=N Committed: https://crrev.com/d58201589bbfa5b320be842e4cb9f14d0e874eb2 Cr-Commit-Position: refs/heads/master@{#34416}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : #

Patch Set 5 : Tweak cctest.status #

Patch Set 6 : Rebase #

Patch Set 7 : TickLinesBaseline now works with more source positions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -71 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/assembler.h View 3 chunks +5 lines, -20 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 5 3 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 4 5 2 chunks +11 lines, -4 lines 0 comments Download
M src/interpreter/source-position-table.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/interpreter/source-position-table.cc View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M src/log.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/ppc/assembler-ppc.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 1 2 3 4 5 1 chunk +9 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 4 5 5 chunks +11 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 33 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/20001
4 years, 10 months ago (2016-02-25 15:36:09 UTC) #2
rmcilroy
Yang, PTAL, thanks.
4 years, 10 months ago (2016-02-25 15:36:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/3475) v8_win_compile_dbg on ...
4 years, 10 months ago (2016-02-25 15:51:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/40001
4 years, 10 months ago (2016-02-26 11:51:26 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14323) v8_linux64_avx2_rel on ...
4 years, 10 months ago (2016-02-26 11:54:13 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/60001
4 years, 10 months ago (2016-02-26 12:15:03 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10717)
4 years, 10 months ago (2016-02-26 12:27:13 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/80001
4 years, 10 months ago (2016-02-26 15:59:37 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/12886)
4 years, 10 months ago (2016-02-26 16:19:03 UTC) #18
Yang
lgtm
4 years, 9 months ago (2016-03-01 11:33:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/80001
4 years, 9 months ago (2016-03-01 19:29:56 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10893) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 19:31:17 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/100001
4 years, 9 months ago (2016-03-02 00:29:59 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2206) v8_linux64_rel_ng_triggered on ...
4 years, 9 months ago (2016-03-02 00:48:24 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737043002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737043002/120001
4 years, 9 months ago (2016-03-02 01:42:36 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-02 02:10:17 UTC) #31
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 02:11:02 UTC) #33
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d58201589bbfa5b320be842e4cb9f14d0e874eb2
Cr-Commit-Position: refs/heads/master@{#34416}

Powered by Google App Engine
This is Rietveld 408576698