Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/snapshot/deserializer.cc

Issue 1751963003: Fix crash when --ll_prof is enabled after cb29f9c (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_profile_sourcepos
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | src/snapshot/serializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/deserializer.cc
diff --git a/src/snapshot/deserializer.cc b/src/snapshot/deserializer.cc
index d7b99858d8aea590d6ddcfbc8aec3e5e7eb71cd6..91b47c54d437ade556290980489295811c8d6fb0 100644
--- a/src/snapshot/deserializer.cc
+++ b/src/snapshot/deserializer.cc
@@ -364,14 +364,15 @@ void Deserializer::ReadObject(int space_number, Object** write_back) {
isolate_->heap()->OnAllocationEvent(obj, size);
Object** current = reinterpret_cast<Object**>(address);
Object** limit = current + (size >> kPointerSizeLog2);
- if (FLAG_log_snapshot_positions) {
- LOG(isolate_, SnapshotPositionEvent(address, source_.position()));
- }
+ int position = source_.position();
if (ReadData(current, limit, space_number, address)) {
// Only post process if object content has not been deferred.
obj = PostProcessNewObject(obj, space_number);
}
+ if (FLAG_log_snapshot_positions) {
+ LOG(isolate_, SnapshotPositionEvent(obj, position));
+ }
Object* write_back_obj = obj;
UnalignedCopy(write_back, &write_back_obj);
« no previous file with comments | « src/log.cc ('k') | src/snapshot/serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698