Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750453002: Reduce ActiveDOMObjects from core/ (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, shans, tzik, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-worker-reviews_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, sof, nhiroki, darktears, michaeln, blink-reviews-animation_chromium.org, serviceworker-reviews, falken, blink-reviews-events_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce ActiveDOMObjects from core/ Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion, this CL replaces a bunch of ActiveDOMObjects in core/ with ContextLifecycleObservers. No change in behavior. BUG=589507 Committed: https://crrev.com/fe7d013fb54ea6a85751043d439930fa85b0c51b Cr-Commit-Position: refs/heads/master@{#378191}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -110 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 4 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryListTest.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.h View 1 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.cpp View 1 3 chunks +6 lines, -10 lines 2 comments Download
M third_party/WebKit/Source/core/page/EventSource.h View 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReader.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.h View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
haraken
PTAL
4 years, 9 months ago (2016-02-29 08:11:43 UTC) #2
sof
https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp File third_party/WebKit/Source/core/css/FontFace.cpp (right): https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp#newcode646 third_party/WebKit/Source/core/css/FontFace.cpp:646: return m_status == Loading && executionContext() && !executionContext()->activeDOMObjectsAreStopped(); So ...
4 years, 9 months ago (2016-02-29 08:38:51 UTC) #3
haraken
https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp File third_party/WebKit/Source/core/css/FontFace.cpp (right): https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp#newcode646 third_party/WebKit/Source/core/css/FontFace.cpp:646: return m_status == Loading && executionContext() && !executionContext()->activeDOMObjectsAreStopped(); On ...
4 years, 9 months ago (2016-02-29 08:58:00 UTC) #4
sof
lgtm https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp File third_party/WebKit/Source/core/css/FontFace.cpp (right): https://codereview.chromium.org/1750453002/diff/40001/third_party/WebKit/Source/core/css/FontFace.cpp#newcode646 third_party/WebKit/Source/core/css/FontFace.cpp:646: return m_status == Loading && executionContext() && !executionContext()->activeDOMObjectsAreStopped(); ...
4 years, 9 months ago (2016-02-29 09:02:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750453002/60001
4 years, 9 months ago (2016-02-29 09:04:54 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-02-29 10:35:54 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/fe7d013fb54ea6a85751043d439930fa85b0c51b Cr-Commit-Position: refs/heads/master@{#378191}
4 years, 9 months ago (2016-02-29 10:37:38 UTC) #10
haraken
https://codereview.chromium.org/1750453002/diff/60001/third_party/WebKit/Source/core/html/PublicURLManager.cpp File third_party/WebKit/Source/core/html/PublicURLManager.cpp (right): https://codereview.chromium.org/1750453002/diff/60001/third_party/WebKit/Source/core/html/PublicURLManager.cpp#newcode49 third_party/WebKit/Source/core/html/PublicURLManager.cpp:49: if (!executionContext()) Sigbjorn: Should we revert this CL for ...
4 years, 9 months ago (2016-03-03 15:31:35 UTC) #11
sof
up to you :) https://codereview.chromium.org/1750453002/diff/60001/third_party/WebKit/Source/core/html/PublicURLManager.cpp File third_party/WebKit/Source/core/html/PublicURLManager.cpp (right): https://codereview.chromium.org/1750453002/diff/60001/third_party/WebKit/Source/core/html/PublicURLManager.cpp#newcode49 third_party/WebKit/Source/core/html/PublicURLManager.cpp:49: if (!executionContext()) On 2016/03/03 15:31:35, ...
4 years, 9 months ago (2016-03-03 15:43:54 UTC) #12
dewittj
4 years, 9 months ago (2016-03-15 23:26:50 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1808533003/ by dewittj@chromium.org.

The reason for reverting is: Revert requested by Ligi Vinod and amineer.

Powered by Google App Engine
This is Rietveld 408576698