third_party/WebKit/Source/core/css/MediaQueryList.h - Issue 1750453002: Reduce ActiveDOMObjects from core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryList.h

Issue 1750453002: Reduce ActiveDOMObjects from core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.cpp ('k') | third_party/WebKit/Source/core/css/MediaQueryList.cpp » ('j') | third_party/WebKit/Source/core/html/PublicURLManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/MediaQueryList.h

diff --git a/third_party/WebKit/Source/core/css/MediaQueryList.h b/third_party/WebKit/Source/core/css/MediaQueryList.h

index 19c9cd764a2231cc94f995d575502a7506fa3a44..37d23522e2cfc1ac2cacf4111ae7046be8608733 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryList.h

+++ b/third_party/WebKit/Source/core/css/MediaQueryList.h

@@ -41,7 +41,7 @@ class MediaQuerySet;

// retrieve the current value of the given media query and to add/remove listeners that

// will be called whenever the value of the query changes.

-class CORE_EXPORT MediaQueryList final : public EventTargetWithInlineData, public RefCountedWillBeNoBase<MediaQueryList>, public ActiveDOMObject {

+class CORE_EXPORT MediaQueryList final : public EventTargetWithInlineData, public RefCountedWillBeNoBase<MediaQueryList>, public ContextLifecycleObserver {

REFCOUNTED_EVENT_TARGET(MediaQueryList);

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaQueryList);

@@ -68,9 +68,8 @@ public:

DECLARE_VIRTUAL_TRACE();

- // From ActiveDOMObject

bool hasPendingActivity() const override;

- void stop() override;

+ void contextDestroyed() override;

const AtomicString& interfaceName() const override;

ExecutionContext* executionContext() const override;