Reduce ActiveDOMObjects from core/

third_party/WebKit/Source/core/css/FontFace.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 120 matching lines @@
         && fontFace->setPropertyFromStyle(properties, CSSPropertyFontDisplay)
         && !fontFace->family().isEmpty()
         && fontFace->traits().bitfield()) {
         fontFace->initCSSFontFace(document, src);
         return fontFace.release();
     }
     return nullptr;
 }
 
 FontFace::FontFace(ExecutionContext* context)
-    : ActiveDOMObject(context)
+    : ContextLifecycleObserver(context)
     , m_status(Unloaded)
 {
-    suspendIfNeeded();
 }
 
 FontFace::FontFace(ExecutionContext* context, const AtomicString& family, const FontFaceDescriptors& descriptors)
-    : ActiveDOMObject(context)
+    : ContextLifecycleObserver(context)
     , m_family(family)
     , m_status(Unloaded)
 {
     Document* document = toDocument(context);
     setPropertyFromString(document, descriptors.style(), CSSPropertyFontStyle);
     setPropertyFromString(document, descriptors.weight(), CSSPropertyFontWeight);
     setPropertyFromString(document, descriptors.stretch(), CSSPropertyFontStretch);
     setPropertyFromString(document, descriptors.unicodeRange(), CSSPropertyUnicodeRange);
     setPropertyFromString(document, descriptors.variant(), CSSPropertyFontVariant);
     setPropertyFromString(document, descriptors.featureSettings(), CSSPropertyFontFeatureSettings);
-
-    suspendIfNeeded();
 }
 
 FontFace::~FontFace()
 {
 }
 
 String FontFace::style() const
 {
     return m_style ? m_style->cssText() : "normal";
 }
@@ skipping 458 matching lines @@
     visitor->trace(m_weight);
     visitor->trace(m_stretch);
     visitor->trace(m_unicodeRange);
     visitor->trace(m_variant);
     visitor->trace(m_featureSettings);
     visitor->trace(m_display);
     visitor->trace(m_error);
     visitor->trace(m_loadedProperty);
     visitor->trace(m_cssFontFace);
     visitor->trace(m_callbacks);
-    ActiveDOMObject::trace(visitor);
+    ContextLifecycleObserver::trace(visitor);
 }
 
 bool FontFace::hadBlankText() const
 {
     return m_cssFontFace->hadBlankText();
 }
 
 bool FontFace::hasPendingActivity() const
 {
     return m_status == Loading && executionContext() && !executionContext()->activeDOMObjectsAreStopped();

[sof, 2016/02/29 08:38:51]

So FontFace is only a ContextLifecycleObserver to support this? Hmm,
unavoidable?

[haraken, 2016/02/29 08:58:00]

Good point. At the very least, we shouldn't need the activeDOMObjectsAreStopped
check.

I think a better fix would be:

- Override contextDebstroyed().
- Call setLoadStatus(Error) in contextDebstroyed().

but it changes the existing behavior. So I reverted the changes to
FontFace.{h,cpp} from this CL. I'll address it in a follow up.

[sof, 2016/02/29 09:02:23]

Thanks, good plan.

 }
 
 } // namespace blink