Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 175017: Experiment with dislodging the Extension Shelf and having it only appear on t... (Closed)

Created:
11 years, 3 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Pam (message me for reviews), Ben Goodger (Google), brettw
Visibility:
Public.

Description

Experiment with dislodging the Extension Shelf and having it only appear on the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24864

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -37 lines) Patch
M chrome/app/chrome_dll.rc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_dll_resource.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 4 5 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/browser_window.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.h View 1 2 3 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_shelf.h View 1 2 3 5 chunks +34 lines, -1 line 0 comments Download
M chrome/browser/views/extensions/extension_shelf.cc View 1 2 3 4 8 chunks +204 lines, -26 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 2 3 5 chunks +26 lines, -4 lines 0 comments Download
M chrome/common/notification_type.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/test_browser_window.h View 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
Known issues: - Animation is slightly janky in debug. Aaron mentioned this is normal for ...
11 years, 3 months ago (2009-08-28 23:04:51 UTC) #1
Erik does not do reviews
11 years, 3 months ago (2009-08-28 23:33:53 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698