Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 175017: Experiment with dislodging the Extension Shelf and having it only appear on t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.h ('k') | chrome/browser/dom_ui/dom_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/gfx/rect.h" 5 #include "base/gfx/rect.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/sys_string_conversions.h" 7 #include "base/sys_string_conversions.h"
8 #include "chrome/browser/bookmarks/bookmark_utils.h" 8 #include "chrome/browser/bookmarks/bookmark_utils.h"
9 #include "chrome/browser/cocoa/browser_window_cocoa.h" 9 #include "chrome/browser/cocoa/browser_window_cocoa.h"
10 #import "chrome/browser/cocoa/browser_window_controller.h" 10 #import "chrome/browser/cocoa/browser_window_controller.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 } 82 }
83 83
84 void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) { 84 void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) {
85 // According to beng, this is an ugly method that comes from the days when the 85 // According to beng, this is an ugly method that comes from the days when the
86 // download shelf was a ChromeView attached to the TabContents, and as its 86 // download shelf was a ChromeView attached to the TabContents, and as its
87 // size changed via animation it notified through TCD/etc to the browser view 87 // size changed via animation it notified through TCD/etc to the browser view
88 // to relayout for each tick of the animation. We don't need anything of the 88 // to relayout for each tick of the animation. We don't need anything of the
89 // sort on Mac. 89 // sort on Mac.
90 } 90 }
91 91
92 void BrowserWindowCocoa::SelectedTabExtensionShelfSizeChanged() {
93 NOTIMPLEMENTED();
94 }
95
92 void BrowserWindowCocoa::UpdateTitleBar() { 96 void BrowserWindowCocoa::UpdateTitleBar() {
93 NSString* newTitle = 97 NSString* newTitle =
94 base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab()); 98 base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
95 99
96 // Window menu 100 // Window menu
97 [NSApp changeWindowsItem:window_ title:newTitle filename:NO]; 101 [NSApp changeWindowsItem:window_ title:newTitle filename:NO];
98 102
99 // Dock 103 // Dock
100 [window_ setMiniwindowTitle:newTitle]; 104 [window_ setMiniwindowTitle:newTitle];
101 } 105 }
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 } 180 }
177 181
178 // This is called from Browser, which in turn is called directly from 182 // This is called from Browser, which in turn is called directly from
179 // a menu option. All we do here is set a preference. The act of 183 // a menu option. All we do here is set a preference. The act of
180 // setting the preference sends notifications to all windows who then 184 // setting the preference sends notifications to all windows who then
181 // know what to do. 185 // know what to do.
182 void BrowserWindowCocoa::ToggleBookmarkBar() { 186 void BrowserWindowCocoa::ToggleBookmarkBar() {
183 bookmark_utils::ToggleWhenVisible(browser_->profile()); 187 bookmark_utils::ToggleWhenVisible(browser_->profile());
184 } 188 }
185 189
190 void BrowserWindowCocoa::ToggleExtensionShelf() {
191 NOTIMPLEMENTED();
192 }
193
186 void BrowserWindowCocoa::AddFindBar( 194 void BrowserWindowCocoa::AddFindBar(
187 FindBarCocoaController* find_bar_cocoa_controller) { 195 FindBarCocoaController* find_bar_cocoa_controller) {
188 return [controller_ addFindBar:find_bar_cocoa_controller]; 196 return [controller_ addFindBar:find_bar_cocoa_controller];
189 } 197 }
190 198
191 void BrowserWindowCocoa::ShowAboutChromeDialog() { 199 void BrowserWindowCocoa::ShowAboutChromeDialog() {
192 NOTIMPLEMENTED(); 200 NOTIMPLEMENTED();
193 } 201 }
194 202
195 void BrowserWindowCocoa::ShowTaskManager() { 203 void BrowserWindowCocoa::ShowTaskManager() {
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 break; 307 break;
300 } 308 }
301 } 309 }
302 310
303 void BrowserWindowCocoa::DestroyBrowser() { 311 void BrowserWindowCocoa::DestroyBrowser() {
304 [controller_ destroyBrowser]; 312 [controller_ destroyBrowser];
305 313
306 // at this point the controller is dead (autoreleased), so 314 // at this point the controller is dead (autoreleased), so
307 // make sure we don't try to reference it any more. 315 // make sure we don't try to reference it any more.
308 } 316 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.h ('k') | chrome/browser/dom_ui/dom_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698