Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/browser.cc

Issue 175017: Experiment with dislodging the Extension Shelf and having it only appear on t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/browser_window.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser.h" 5 #include "chrome/browser/browser.h"
6 6
7 #include "app/animation.h" 7 #include "app/animation.h"
8 #include "app/l10n_util.h" 8 #include "app/l10n_util.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/idle_timer.h" 10 #include "base/idle_timer.h"
(...skipping 1131 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 void Browser::OpenBugReportDialog() { 1142 void Browser::OpenBugReportDialog() {
1143 UserMetrics::RecordAction(L"ReportBug", profile_); 1143 UserMetrics::RecordAction(L"ReportBug", profile_);
1144 window_->ShowReportBugDialog(); 1144 window_->ShowReportBugDialog();
1145 } 1145 }
1146 1146
1147 void Browser::ToggleBookmarkBar() { 1147 void Browser::ToggleBookmarkBar() {
1148 UserMetrics::RecordAction(L"ShowBookmarksBar", profile_); 1148 UserMetrics::RecordAction(L"ShowBookmarksBar", profile_);
1149 window_->ToggleBookmarkBar(); 1149 window_->ToggleBookmarkBar();
1150 } 1150 }
1151 1151
1152 void Browser::ToggleExtensionShelf() {
1153 UserMetrics::RecordAction(L"ToggleExtensionShelf", profile_);
1154 window_->ToggleExtensionShelf();
1155 }
1156
1152 void Browser::OpenBookmarkManager() { 1157 void Browser::OpenBookmarkManager() {
1153 UserMetrics::RecordAction(L"ShowBookmarkManager", profile_); 1158 UserMetrics::RecordAction(L"ShowBookmarkManager", profile_);
1154 window_->ShowBookmarkManager(); 1159 window_->ShowBookmarkManager();
1155 } 1160 }
1156 1161
1157 void Browser::ShowAppMenu() { 1162 void Browser::ShowAppMenu() {
1158 UserMetrics::RecordAction(L"ShowAppMenu", profile_); 1163 UserMetrics::RecordAction(L"ShowAppMenu", profile_);
1159 window_->ShowAppMenu(); 1164 window_->ShowAppMenu();
1160 } 1165 }
1161 1166
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1271 prefs->RegisterStringPref(prefs::kRecentlySelectedEncoding, L""); 1276 prefs->RegisterStringPref(prefs::kRecentlySelectedEncoding, L"");
1272 prefs->RegisterBooleanPref(prefs::kDeleteBrowsingHistory, true); 1277 prefs->RegisterBooleanPref(prefs::kDeleteBrowsingHistory, true);
1273 prefs->RegisterBooleanPref(prefs::kDeleteDownloadHistory, true); 1278 prefs->RegisterBooleanPref(prefs::kDeleteDownloadHistory, true);
1274 prefs->RegisterBooleanPref(prefs::kDeleteCache, true); 1279 prefs->RegisterBooleanPref(prefs::kDeleteCache, true);
1275 prefs->RegisterBooleanPref(prefs::kDeleteCookies, true); 1280 prefs->RegisterBooleanPref(prefs::kDeleteCookies, true);
1276 prefs->RegisterBooleanPref(prefs::kDeletePasswords, false); 1281 prefs->RegisterBooleanPref(prefs::kDeletePasswords, false);
1277 prefs->RegisterBooleanPref(prefs::kDeleteFormData, true); 1282 prefs->RegisterBooleanPref(prefs::kDeleteFormData, true);
1278 prefs->RegisterIntegerPref(prefs::kDeleteTimePeriod, 0); 1283 prefs->RegisterIntegerPref(prefs::kDeleteTimePeriod, 0);
1279 prefs->RegisterBooleanPref(prefs::kCheckDefaultBrowser, true); 1284 prefs->RegisterBooleanPref(prefs::kCheckDefaultBrowser, true);
1280 prefs->RegisterBooleanPref(prefs::kShowOmniboxSearchHint, true); 1285 prefs->RegisterBooleanPref(prefs::kShowOmniboxSearchHint, true);
1286 prefs->RegisterBooleanPref(prefs::kShowExtensionShelf, true);
1281 } 1287 }
1282 1288
1283 // static 1289 // static
1284 Browser* Browser::GetBrowserForController( 1290 Browser* Browser::GetBrowserForController(
1285 const NavigationController* controller, int* index_result) { 1291 const NavigationController* controller, int* index_result) {
1286 BrowserList::const_iterator it; 1292 BrowserList::const_iterator it;
1287 for (it = BrowserList::begin(); it != BrowserList::end(); ++it) { 1293 for (it = BrowserList::begin(); it != BrowserList::end(); ++it) {
1288 int index = (*it)->tabstrip_model_.GetIndexOfController(controller); 1294 int index = (*it)->tabstrip_model_.GetIndexOfController(controller);
1289 if (index != TabStripModel::kNoTab) { 1295 if (index != TabStripModel::kNoTab) {
1290 if (index_result) 1296 if (index_result)
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1428 // Show various bits of UI 1434 // Show various bits of UI
1429 case IDC_OPEN_FILE: OpenFile(); break; 1435 case IDC_OPEN_FILE: OpenFile(); break;
1430 case IDC_CREATE_SHORTCUTS: OpenCreateShortcutsDialog(); break; 1436 case IDC_CREATE_SHORTCUTS: OpenCreateShortcutsDialog(); break;
1431 case IDC_DEV_TOOLS: ToggleDevToolsWindow(); break; 1437 case IDC_DEV_TOOLS: ToggleDevToolsWindow(); break;
1432 case IDC_TASK_MANAGER: OpenTaskManager(); break; 1438 case IDC_TASK_MANAGER: OpenTaskManager(); break;
1433 case IDC_SELECT_PROFILE: OpenSelectProfileDialog(); break; 1439 case IDC_SELECT_PROFILE: OpenSelectProfileDialog(); break;
1434 case IDC_NEW_PROFILE: OpenNewProfileDialog(); break; 1440 case IDC_NEW_PROFILE: OpenNewProfileDialog(); break;
1435 case IDC_REPORT_BUG: OpenBugReportDialog(); break; 1441 case IDC_REPORT_BUG: OpenBugReportDialog(); break;
1436 1442
1437 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break; 1443 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break;
1444 case IDC_SHOW_EXTENSION_SHELF: ToggleExtensionShelf(); break;
1438 1445
1439 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break; 1446 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break;
1440 case IDC_SHOW_HISTORY: ShowHistoryTab(); break; 1447 case IDC_SHOW_HISTORY: ShowHistoryTab(); break;
1441 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break; 1448 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break;
1442 case IDC_SHOW_APP_MENU: ShowAppMenu(); break; 1449 case IDC_SHOW_APP_MENU: ShowAppMenu(); break;
1443 case IDC_SHOW_PAGE_MENU: ShowPageMenu(); break; 1450 case IDC_SHOW_PAGE_MENU: ShowPageMenu(); break;
1444 #ifdef CHROME_PERSONALIZATION 1451 #ifdef CHROME_PERSONALIZATION
1445 case IDC_SYNC_BOOKMARKS: OpenSyncMyBookmarksDialog(); break; 1452 case IDC_SYNC_BOOKMARKS: OpenSyncMyBookmarksDialog(); break;
1446 #endif 1453 #endif
1447 case IDC_OPTIONS: OpenOptionsDialog(); break; 1454 case IDC_OPTIONS: OpenOptionsDialog(); break;
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
1903 return (type() & TYPE_POPUP); 1910 return (type() & TYPE_POPUP);
1904 } 1911 }
1905 1912
1906 void Browser::ToolbarSizeChanged(TabContents* source, bool is_animating) { 1913 void Browser::ToolbarSizeChanged(TabContents* source, bool is_animating) {
1907 if (source == GetSelectedTabContents() || source == NULL) { 1914 if (source == GetSelectedTabContents() || source == NULL) {
1908 // This will refresh the shelf if needed. 1915 // This will refresh the shelf if needed.
1909 window_->SelectedTabToolbarSizeChanged(is_animating); 1916 window_->SelectedTabToolbarSizeChanged(is_animating);
1910 } 1917 }
1911 } 1918 }
1912 1919
1920 void Browser::ExtensionShelfSizeChanged() {
1921 window_->SelectedTabExtensionShelfSizeChanged();
1922 }
1923
1913 void Browser::URLStarredChanged(TabContents* source, bool starred) { 1924 void Browser::URLStarredChanged(TabContents* source, bool starred) {
1914 if (source == GetSelectedTabContents()) 1925 if (source == GetSelectedTabContents())
1915 window_->SetStarredState(starred); 1926 window_->SetStarredState(starred);
1916 } 1927 }
1917 1928
1918 void Browser::ContentsMouseEvent(TabContents* source, bool motion) { 1929 void Browser::ContentsMouseEvent(TabContents* source, bool motion) {
1919 if (!GetStatusBubble()) 1930 if (!GetStatusBubble())
1920 return; 1931 return;
1921 1932
1922 if (source == GetSelectedTabContents()) { 1933 if (source == GetSelectedTabContents()) {
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
2234 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true); 2245 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true);
2235 2246
2236 // Show various bits of UI 2247 // Show various bits of UI
2237 command_updater_.UpdateCommandEnabled(IDC_OPEN_FILE, true); 2248 command_updater_.UpdateCommandEnabled(IDC_OPEN_FILE, true);
2238 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false); 2249 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
2239 command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS, true); 2250 command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS, true);
2240 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true); 2251 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true);
2241 command_updater_.UpdateCommandEnabled(IDC_SELECT_PROFILE, true); 2252 command_updater_.UpdateCommandEnabled(IDC_SELECT_PROFILE, true);
2242 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true); 2253 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true);
2243 command_updater_.UpdateCommandEnabled(IDC_SHOW_BOOKMARK_MANAGER, true); 2254 command_updater_.UpdateCommandEnabled(IDC_SHOW_BOOKMARK_MANAGER, true);
2255 command_updater_.UpdateCommandEnabled(IDC_SHOW_EXTENSION_SHELF, true);
2244 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true); 2256 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
2245 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE, true); 2257 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE, true);
2246 #if defined(OS_CHROMEOS) 2258 #if defined(OS_CHROMEOS)
2247 command_updater_.UpdateCommandEnabled(IDC_CONTROL_PANEL, true); 2259 command_updater_.UpdateCommandEnabled(IDC_CONTROL_PANEL, true);
2248 #endif 2260 #endif
2249 2261
2250 // Initialize other commands based on the window type. 2262 // Initialize other commands based on the window type.
2251 { 2263 {
2252 bool normal_window = type() == TYPE_NORMAL; 2264 bool normal_window = type() == TYPE_NORMAL;
2253 2265
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
2836 /////////////////////////////////////////////////////////////////////////////// 2848 ///////////////////////////////////////////////////////////////////////////////
2837 // BrowserToolbarModel (private): 2849 // BrowserToolbarModel (private):
2838 2850
2839 NavigationController* Browser::BrowserToolbarModel::GetNavigationController() { 2851 NavigationController* Browser::BrowserToolbarModel::GetNavigationController() {
2840 // This |current_tab| can be NULL during the initialization of the 2852 // This |current_tab| can be NULL during the initialization of the
2841 // toolbar during window creation (i.e. before any tabs have been added 2853 // toolbar during window creation (i.e. before any tabs have been added
2842 // to the window). 2854 // to the window).
2843 TabContents* current_tab = browser_->GetSelectedTabContents(); 2855 TabContents* current_tab = browser_->GetSelectedTabContents();
2844 return current_tab ? &current_tab->controller() : NULL; 2856 return current_tab ? &current_tab->controller() : NULL;
2845 } 2857 }
OLDNEW
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698