Ellipsize long entries in bookmark menus and the back/forward menus....

Ellipsize long entries in bookmark menus and the back/forward menus.

Also ellipsize long tooltips.

Also make the bookmark bar tooltips more like window (Title on one line, then url on the next line). I've made the title bold, although that isn't the case on windows.

Menus: Prefer popping downwards rather than upwards when there is more space down than up.

BUG=18617
BUG=20120
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24685

[Elliot Glaysher, 2009-08-27 22:54:06]

LGTM

[tony, 2009-08-27 23:01:04]

http://codereview.chromium.org/175004/diff/3004/2007
File chrome/browser/gtk/back_forward_menu_model_gtk.cc (right):

http://codereview.chromium.org/175004/diff/3004/2007#newcode33
Line 33: item_label_wstr = l10n_util::TruncateString(item_label_wstr,
kMaxChars);
It looks like there's an width-chars property on GtkMenuItem.  Can we use that
instead?

[Evan Stade, 2009-08-27 23:02:27]

http://codereview.chromium.org/175004/diff/3004/2007
File chrome/browser/gtk/back_forward_menu_model_gtk.cc (right):

http://codereview.chromium.org/175004/diff/3004/2007#newcode33
Line 33: item_label_wstr = l10n_util::TruncateString(item_label_wstr,
kMaxChars);
On 2009/08/27 23:01:04, tony wrote:
> It looks like there's an width-chars property on GtkMenuItem.  Can we use that
> instead?

The "width-chars" style property

  "width-chars"              gint                  : Read
The minimum desired width of the menu item in characters.

[tony, 2009-08-27 23:10:46]

On 2009/08/27 23:02:27, Evan Stade wrote:
> http://codereview.chromium.org/175004/diff/3004/2007
> File chrome/browser/gtk/back_forward_menu_model_gtk.cc (right):
> 
> http://codereview.chromium.org/175004/diff/3004/2007#newcode33
> Line 33: item_label_wstr = l10n_util::TruncateString(item_label_wstr,
> kMaxChars);
> On 2009/08/27 23:01:04, tony wrote:
> > It looks like there's an width-chars property on GtkMenuItem.  Can we use
that
> > instead?
> 
> The "width-chars" style property
> 
>   "width-chars"              gint                  : Read
> The minimum desired width of the menu item in characters.

Ah right, I should actually read the docs.

LGTM