Ellipsize long entries in bookmark menus and the back/forward menus....

chrome/browser/gtk/bookmark_menu_controller_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/bookmark_menu_controller_gtk.h"
 
 #include <gtk/gtk.h>
 
 #include "app/gtk_dnd_util.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/gfx/gtk_util.h"
 #include "base/string_util.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/gtk/bookmark_context_menu.h"
 #include "chrome/browser/gtk/bookmark_utils_gtk.h"
 #include "chrome/browser/gtk/gtk_chrome_button.h"
 #include "chrome/browser/gtk/gtk_theme_provider.h"
 #include "chrome/browser/gtk/menu_gtk.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/tab_contents/page_navigator.h"
 #include "chrome/common/gtk_util.h"
 #include "grit/app_resources.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "webkit/glue/window_open_disposition.h"
 
 namespace {
 
+// TODO(estade): It might be a good idea to vary this by locale.
+const int kMaxChars = 50;
+
 void SetImageMenuItem(GtkWidget* menu_item, const SkBitmap& bitmap) {
   GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(&bitmap);
   gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(menu_item),
                                 gtk_image_new_from_pixbuf(pixbuf));
   g_object_unref(pixbuf);
 }
 
 const BookmarkNode* GetNodeFromMenuItem(GtkWidget* menu_item) {
   return static_cast<const BookmarkNode*>(
       g_object_get_data(G_OBJECT(menu_item), "bookmark-node"));
@@ skipping 103 matching lines @@
                                        GtkWidget* menu) {
   DCHECK(!parent->GetChildCount() ||
          start_child_index < parent->GetChildCount());
 
   g_signal_connect(G_OBJECT(menu), "button-press-event",
                    G_CALLBACK(OnButtonPressed), this);
 
   for (int i = start_child_index; i < parent->GetChildCount(); ++i) {
     const BookmarkNode* node = parent->GetChild(i);
 
-    GtkWidget* menu_item = gtk_image_menu_item_new_with_label(
-        WideToUTF8(node->GetTitle()).c_str());
+    // This breaks on word boundaries. Ideally we would break on character
+    // boundaries.
+    std::wstring elided_name =
+        l10n_util::TruncateString(node->GetTitle(), kMaxChars);
+    GtkWidget* menu_item =
+        gtk_image_menu_item_new_with_label(WideToUTF8(elided_name).c_str());
     g_object_set_data(G_OBJECT(menu_item), "bookmark-node", AsVoid(node));
 
     if (node->is_url()) {
       SkBitmap icon = profile_->GetBookmarkModel()->GetFavIcon(node);
       if (icon.width() == 0) {
         icon = *ResourceBundle::GetSharedInstance().
             GetBitmapNamed(IDR_DEFAULT_FAVICON);
       }
       SetImageMenuItem(menu_item, icon);
       g_signal_connect(G_OBJECT(menu_item), "activate",
@@ skipping 173 matching lines @@
 // static
 void BookmarkMenuController::OnMenuItemDragGet(
     GtkWidget* widget, GdkDragContext* context,
     GtkSelectionData* selection_data,
     guint target_type, guint time,
     BookmarkMenuController* controller) {
   const BookmarkNode* node = bookmark_utils::BookmarkNodeForWidget(widget);
   bookmark_utils::WriteBookmarkToSelection(node, selection_data, target_type,
                                            controller->profile_);
 }