Ellipsize long entries in bookmark menus and the back/forward menus....

chrome/browser/gtk/bookmark_utils_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/bookmark_utils_gtk.h"
 
 #include "app/gtk_dnd_util.h"
+#include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/gfx/gtk_util.h"
 #include "base/pickle.h"
 #include "base/string_util.h"
 #include "chrome/browser/bookmarks/bookmark_drag_data.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/gtk/gtk_chrome_button.h"
 #include "chrome/browser/gtk/gtk_theme_provider.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/gtk_util.h"
 #include "grit/app_resources.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 
 namespace {
 
 // Used in gtk_selection_data_set(). (I assume from this parameter that gtk has
 // to some really exotic hardware...)
 const int kBitsInAByte = 8;
 
 // Maximum number of characters on a bookmark button.
 const size_t kMaxCharsOnAButton = 15;
 
+// Max size of each component of the button tooltips.
+const size_t kMaxTooltipTitleLength = 100;
+const size_t kMaxTooltipURLLength = 400;
+
 // Only used for the background of the drag widget.
 const GdkColor kBackgroundColor = GDK_COLOR_RGB(0xe6, 0xed, 0xf4);
 
 // Padding between the chrome button highlight border and the contents (favicon,
 // text).
 // TODO(estade): we need to adjust the top and bottom padding, but first we need
 // to give the bookmark bar more space (at the expense of the toolbar).
 const int kButtonPaddingTop = 0;
 const int kButtonPaddingBottom = 0;
 const int kButtonPaddingLeft = 2;
@@ skipping 98 matching lines @@
 }
 
 void ConfigureButtonForNode(const BookmarkNode* node, BookmarkModel* model,
                             GtkWidget* button, GtkThemeProvider* provider) {
   GtkWidget* former_child = gtk_bin_get_child(GTK_BIN(button));
   if (former_child)
     gtk_container_remove(GTK_CONTAINER(button), former_child);
 
   std::string tooltip = BuildTooltipFor(node);
   if (!tooltip.empty())
-    gtk_widget_set_tooltip_text(button, tooltip.c_str());
+    gtk_widget_set_tooltip_markup(button, tooltip.c_str());
 
   // We pack the button manually (rather than using gtk_button_set_*) so that
   // we can have finer control over its label.
   GdkPixbuf* pixbuf = bookmark_utils::GetPixbufForNode(node, model,
                                                        provider->UseGtkTheme());
   GtkWidget* image = gtk_image_new_from_pixbuf(pixbuf);
   g_object_unref(pixbuf);
 
   GtkWidget* box = gtk_hbox_new(FALSE, kBarButtonPadding);
   gtk_box_pack_start(GTK_BOX(box), image, FALSE, FALSE, 0);
@@ skipping 18 matching lines @@
   gtk_container_add(GTK_CONTAINER(alignment), box);
   gtk_container_add(GTK_CONTAINER(button), alignment);
 
   g_object_set_data(G_OBJECT(button), bookmark_utils::kBookmarkNode,
                     AsVoid(node));
 
   gtk_widget_show_all(alignment);
 }
 
 std::string BuildTooltipFor(const BookmarkNode* node) {
-  // TODO(erg): Actually build the tooltip. For now, we punt and just return
-  // the URL.
-  return node->GetURL().possibly_invalid_spec();
+  const std::string& url = node->GetURL().possibly_invalid_spec();
+  const std::string& title = WideToUTF8(node->GetTitle());
+
+  std::string truncated_url = WideToUTF8(l10n_util::TruncateString(
+      UTF8ToWide(url), kMaxTooltipURLLength));
+  gchar* escaped_url_cstr = g_markup_escape_text(truncated_url.c_str(),
+                                                 truncated_url.size());
+  std::string escaped_url(escaped_url_cstr);
+  g_free(escaped_url_cstr);
+
+  std::string tooltip;
+  if (url == title) {
+    return escaped_url;
+  } else {
+    std::string truncated_title = WideToUTF8(l10n_util::TruncateString(
+      node->GetTitle(), kMaxTooltipTitleLength));
+    gchar* escaped_title_cstr = g_markup_escape_text(truncated_title.c_str(),
+                                                     truncated_title.size());
+    std::string escaped_title(escaped_title_cstr);
+    g_free(escaped_title_cstr);
+
+    return std::string("<b>") + escaped_title + "</b>\n" + escaped_url;
+  }
 }
 
 const BookmarkNode* BookmarkNodeForWidget(GtkWidget* widget) {
   return reinterpret_cast<const BookmarkNode*>(
       g_object_get_data(G_OBJECT(widget), bookmark_utils::kBookmarkNode));
 }
 
 void SetButtonTextColors(GtkWidget* label, GtkThemeProvider* provider) {
   if (provider->UseGtkTheme()) {
     gtk_util::SetLabelColor(label, NULL);
@@ skipping 105 matching lines @@
   std::vector<GURL> urls;
   GtkDndUtil::ExtractURIList(selection_data, &urls);
   for (size_t i = 0; i < urls.size(); ++i) {
     std::string title = GetNameForURL(urls[i]);
     model->AddURL(parent, idx++, UTF8ToWide(title), urls[i]);
   }
   return true;
 }
 
 }  // namespace bookmark_utils