Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_dialog_controller.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc
index b9413a0f7cee7f60dc6784884c23ffe8f572b8e8..8f509b85c6d3eb84d67b461245da84ada2478ba0 100644
--- a/chrome/browser/printing/print_preview_dialog_controller.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller.cc
@@ -388,8 +388,6 @@ void PrintPreviewDialogController::OnNavEntryCommitted(
NOTREACHED();
return;
}
-
- RemoveInitiatorTab(contents);
Lei Zhang 2013/06/27 00:31:18 Once we do this, then maybe we don't even need wat
Mike Wittman 2013/06/27 00:58:11 Yes, that's true. It would require a bit more comp
Lei Zhang 2013/06/27 02:29:37 Yes it would. If you don't want to, then just put
Mike Wittman 2013/06/27 17:34:04 Not a problem, added the additional logic to not o
}
WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(
« no previous file with comments | « no previous file | chrome/browser/printing/print_view_manager.cc » ('j') | chrome/browser/printing/print_view_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698