Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1979)

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_view_manager.cc
diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc
index f5efeb714f15704be6e2b0936599260865609571..2aca362e70232b969857d8eccc5f74e18c238cf5 100644
--- a/chrome/browser/printing/print_view_manager.cc
+++ b/chrome/browser/printing/print_view_manager.cc
@@ -153,7 +153,6 @@ void PrintViewManager::PrintPreviewForWebNode() {
void PrintViewManager::PrintPreviewDone() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK_NE(NOT_PREVIEWING, print_preview_state_);
Lei Zhang 2013/06/27 02:28:46 If I put this DCHECK back, I can't seem to trigger
Mike Wittman 2013/06/27 17:34:04 I didn't experience this DCHECK firing while runni
Lei Zhang 2013/06/27 21:36:18 No luck for me on Linux-views. I'll fire up the Wi
if (print_preview_state_ == SCRIPTED_PREVIEW) {
ScriptedPrintPreviewClosureMap& map =

Powered by Google App Engine
This is Rietveld 408576698